Improved termination - Githubissues

DOAJ / harvester

External library which can harvest content from 3rd parties and add them to the DOAJ via its API

3 stars 0 forks source link

Improved termination #5

Closed Steven-Eardley closed 7 years ago

Steven-Eardley commented 7 years ago

Harvester will kill old versions when it runs, and prevent more than one from starting simultaneously.
Harvester process now saves state when sent a SIGTERM or KeyboardInterrupt.

emanuil-tolev commented 7 years ago

I've added a note to the process management issue of something that Richard mentioned but we forgot to include in the implementation notes - devs should be able to skip the 10-min wait. Making it a config value that is 10 min by default and enforcing a minimum (of 5-10 seconds) should work well.

EDIT: bottom of https://github.com/DOAJ/harvester/issues/3#issuecomment-313140033

Steven-Eardley commented 7 years ago

Of course, silly of me to make it a constant but not an app configuration. However, as implemented, it doesn't always wait 10 minutes - that's just a max. If there's nothing to kill then it'll just carry on booting.