DOCGroup / ACE_TAO

ACE and TAO
https://www.dre.vanderbilt.edu/~schmidt/TAO.html
698 stars 374 forks source link

reserved identifier violation #2155

Open elfring opened 10 months ago

elfring commented 10 months ago

I would like to point out that identifiers like “_AST_DECL_AST_DECL_HH” and “_COMM_MANAGER_Hdo not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

mitza-oci commented 10 months ago

There are uses of preprocessor identifiers (and probably others) that do not conform to what the standard requires because they're reserved. I think a contribution to change this would be welcome.

elfring commented 10 months ago

:thought_balloon: Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

jwillemsen commented 10 months ago

Feel free to use a tool to make a proposed pull request