search

DOCGroup / ACE_TAO

ACE and TAO
https://www.dre.vanderbilt.edu/~schmidt/TAO.html
698 stars 374 forks source link

wxNamingViewer: build with wxWidgets 3.2 #2169

Open saper opened 9 months ago

saper commented 9 months ago

The patches attached are needed to build and run wxNamingViewer with wxWidgets 3.2

For most existing code I could not identify which version of wxWindows/wxWidgets it could have worked last time, therefore a generic #ifdef has been used.

If no support for old frameworks is needed, those could be removed.

mitza-oci commented 9 months ago

Thanks for working on this. Would it be feasible to update one of the GitHub Actions builds to enable wxWidgets?

saper commented 9 months ago

Thanks for working on this. Would it be feasible to update one of the GitHub Actions builds to enable wxWidgets?

Sure, tried this https://github.com/DOCGroup/ACE_TAO/pull/2169/commits/74ba32c3811ed3d73c8bcb8e56b03efa8b7799e8 but it looks like the build does not even descend into the utils directory as it did for me: https://github.com/DOCGroup/ACE_TAO/actions/runs/7023541947/job/19110306550?pr=2169

mitza-oci commented 9 months ago

It's running the makefile but not building anything yet. https://github.com/DOCGroup/ACE_TAO/actions/runs/7023541947/job/19110306550?pr=2169#step:18:4354 One of the earlier steps that writes to platform_macros.GNU needs to add wxWindows=1 to it