search

DOCGroup / ACE_TAO

ACE and TAO
https://www.dre.vanderbilt.edu/~schmidt/TAO.html
691 stars 375 forks source link

[ace6tao2] Comparison warning in CDR_Base.cpp #2219

Open jwillemsen opened 3 months ago

jwillemsen commented 3 months ago

Warning in ACE using bcc32 on ace6tao2 branch, introduced by https://github.com/DOCGroup/ACE_TAO/pull/2196

.\CDR_Base.cpp:
Warning W8012 .\CDR_Base.cpp 938: Comparing signed and unsigned values in function ACE_CDR::Fixed::from_string(const char *)
mitza-oci commented 3 months ago

Both sides of the comparison are unsigned. Is there a CI build that shows the warning - or could one be added?

jwillemsen commented 3 months ago

Working on new CI builds, need to create first a base line. Are they different sizes, if so, one could be promoted to signed before the comparison

jwillemsen commented 3 months ago

See https://download.remedy.nl/buildlogs/win_cbxe15_bcc32_acetao_debug/

iguessthislldo commented 2 months ago

It's size_t and an unsigned char. Why would a compiler change the signedness (apparently that's a real word) of a value and then complain about it?