DOCGroup / ACE_TAO

ACE and TAO
https://www.dre.vanderbilt.edu/~schmidt/TAO.html
704 stars 380 forks source link

Fix `ACE_Logging_Strategy::handle_timeout` returning `-1` without releasing `ACE_Log_Msg` lock #2259

Open likema opened 4 months ago

likema commented 4 months ago

Before changed, there were two snippets in ACE_Logging_Strategy::handle_timeout :

if (output_file == 0)
        return -1;

whiich would return without releasing ACE_Log_Msg lock

jwillemsen commented 3 months ago

Don’t force push, makes it harder to review, use nullptr instead of 0

likema commented 3 months ago

Don’t force push, makes it harder to review, use nullptr instead of 0

OK. Shall I combine two commits into one after reviewed so that keep one issue per commit?

jwillemsen commented 3 months ago

No need to squash, please add/extend a unit test as reproducer