Build NRRD Site Map

[ghost]

https://vp0fb7.axshare.com

[ghost]

@Maroyafaied this is ready for your review

[Maroyafaied]

@daniel-coleman-1 I have reviewed and added a bunch of comments, I also noticed this page is missing https://revenuedata.doi.gov/how-revenue-works/revenues. @mcharg could you also review when you have time. Thanks

[mcharg]

@daniel-coleman-1 I reviewed Explore Data and Query Data and added some comments about how to organize them. Let me know if you want to jump on a call to discuss.

[ghost]

@mcharg I've implemented changes in Explore Data, but left out numbers on the lower portion. Hoping you have some guidance on setting numbers with this structure.

https://vp0fb7.axshare.com

[mcharg]

@daniel-coleman-1 I reviewed Explore Data > Revenue. You should be able to extrapolate those comments to Production and Disbursements.

[ghost]

@mcharg and @Maroyafaied thank you for the notes, I've updated it in a manner that I think best represents what you're thinking. Could you take another look?

[Maroyafaied]

@daniel-coleman-1 I reviewed the homepage and listed my comments, here is a summary of my comments.

[Maroyafaied]

@daniel-coleman-1 sorry, I didn't finish my comment but I reviewed the homepage, it's looking good. Here are a summary of my comments on the homepage. I also reviewed section 5.13 and left a couple of comments on that page.

1. The "source" breakout is missing under revenue>yearly>fiscal year. It should be 0.2.1.1.1 before revenue type.
2. 0.3.1.2 should be called Recipient instead of revenue
3. I tagged @mcharg in the comments but I'm thinking the source files don't need to be listed multiple times since they don't change once you select yearly or monthly for each data type. Also the numbering under each source file need to change , here is what they should be.
   • Revenue Yearly and Revenue Monthly (3.3)
   • Disbursements Yearly (3.6), Disbursements Monthly (3.5)
   • Production Yearly and Monthly (3.1)

[mcharg]

@daniel-coleman-1 I took another pass through Explore Data. There are a number of my previous comments that weren't resolved.

[ghost]

@mcharg can we jump on a call to discuss? I know you're heading out for the weekend soon so Monday morning works

[mcharg]

@daniel-coleman-1 Sorry, I'd already logged off for the day on Friday. I sent you an invite for a call this morning.

[ghost]

@mcharg thanks for chatting earlier, I have updated the sitemap with the changes we discussed: https://vp0fb7.axshare.com

[mcharg]

@daniel-coleman-1 I took another pass through Explore Data and Query Data. You need to go through the site with a fine toothed comb and see what changes when you interact. That's all I'm doing when I review and I shouldn't have to be documenting as many things as I am.

[ghost]

@Maroyafaied this is ready for review.

[Maroyafaied]

Thanks I'll review, @mcharg can you review the query and explore data.

[Maroyafaied]

@daniel-coleman-1 I only looked at the homepage, these comments highlighted still need to be addressed that I mentioned in my previous review.

[Maroyafaied]

@daniel-coleman-1 I'm responding to your comment on the nrrd-git-feed channel, again please comment on the actual issue and not in that channel. Here are pics of what I'm referring to, we can meet tomorrow if this still doesn't make sense.

Under fiscal year revenue, you need to add a box for the "Source" breakout like you have under calendar year. It needs to go before revenue type like you have it for calendar year.

All the source files for monthly disbursements should be 3.5 not 3.6

[ghost]

@Maroyafaied ahhhh ok I understand what you're saying

[Maroyafaied]

@daniel-coleman-1 I made a comment on 3.0 Download Data to add a box for this historical revenue data we just added to the website and the files. Please let me know when that update is made and when the homepage is ready for review again.

[mcharg]

@daniel-coleman-1 It doesn't look like you resolved any of my comments on Explore Data and I noted which are still outstanding for Query Data.

[ghost]

@mcharg I may not be understanding what you're trying to communicate, I'll take another look later today and may schedule some time for us to talk tomorrow to get on the same page

[mcharg]

@daniel-coleman-1 We've already walked through it and you didn't make the changes we talked about, so I added them as comments and you still didn't make the changes. Not sure how much clearer I can be.

[ghost]

@mcharg yes seems like a communication breakdown. Let's get some time to talk.

[ghost]

ok @mcharg this is ready for a (hopefully final) review

[mcharg]

@daniel-coleman-1 It'll likely be Monday before I get a chance to review. I've got a lot going on today and you told me you'd have this ready to review by EOD Wednesday, so I didn't plan on having to review it today.

[mcharg]

@daniel-coleman-1 I reviewed the revenue sections for both Explore Data and Query Data. Most of what we discussed in our last meeting wasn't correctly addressed.

[Maroyafaied]

@mcharg @daniel-coleman-1 I'm going to set up a meeting to discuss and to decide how to move forward with this task.

[Maroyafaied]

We discussed that it's taking a lot of time to review and get this task done so we will revisit this task later on when we have to time to focus on the NRRD.