Review State Navigation Page

DOI-ONRR / nrrd

ONRR open data site hosted on cloud.gov

Other

13 stars 5 forks source link

Review State Navigation Page #3474

Closed AlexandracmONRR closed 5 days ago

AlexandracmONRR commented 2 weeks ago

Homepage State Nav Page

Reviews

[x] Accessibility Manual check (Lindsay)
[x] Accessibility Automated check (Alex, Wave, Lighthouse)
[x] Content Review (Christine)
[x] Link Review (Christine)

AlexandracmONRR commented 1 week ago

@lpgoldstein and @cthomasONRR - I've added you to this review, please let me know if you prefer a different part to review!

cthomasONRR commented 1 week ago

@AlexandracmONRR

Could you make the homepage link sentence case? These highlighted uppercase letters can be lower case.

Can you make content on the state nav page be in sentence case? These highlighted uppercase letters can be lower case. Since explore data and query data links are within a sentence and they're not really proper nouns, they can also be lower case.
Also, should this say "explore data AND query data"?

cthomasONRR commented 1 week ago

@AlexandracmONRR

This isn't really an issue, more of a question. Is there a reason why the states are 4 to a row and the offshore regions are only 3 to a row? Is it that the text length of each offshore region name prevents them from being 4 in one row? If possible, it would be nice to have all 4 offshore regions in one row, but not super necessary/important.

AlexandracmONRR commented 1 week ago

@cthomasONRR I think that has to do with screen size and the margin/padding around each button. For me it is showing up as 4 buttons across the screen:

cthomasONRR commented 1 week ago

@AlexandracmONRR All links look good! Let me know when you have content corrections made and I'll review those again. Great work, thanks!

lpgoldstein commented 1 week ago

homepage - SVG should be hidden

here is an example of how the other links next to "Data by state and offshore region appear"

AlexandracmONRR commented 1 week ago

@CthomasONRR - i made the corrections the casing that you found @lpgoldstein - I will need to ask jeff to hide the svg

AlexandracmONRR commented 6 days ago

Passed the WAVE check.

The only errors or alerts found were not related to the state nav page. They were related to the search box (missing form label), contrast errors in footer (footer doesn't present correctly in preview site), and 4 alerts related to images in the footer (footer doesn't present correctly in preview site).

AlexandracmONRR commented 6 days ago

Passed Lighthouse check.

100 in Accessibility.

68 in Performance. Warning for total blocking time and speed index. Diagnostics alerted us to minimize main-thread work, reduce javascript execution time, and reduce unused javascript.

cthomasONRR commented 5 days ago

@AlexandracmONRR The content updates look good! Thanks!

AlexandracmONRR commented 5 days ago

@cthomasONRR and @lpgoldstein - thank you for your review and feedback!

I've created a separate issue for jeff to hide the svg for when he gets back and then this will be ready to merge.

This issue will be closed!