search

DOI-USGS / COAWST

COAWST modeling system git repository
Other
110 stars 52 forks source link

Issue with WEC_VF in ROMS-SWAN coupled model #234

Closed ocean0510 closed 8 months ago

ocean0510 commented 8 months ago

Hello,

We are currently using the ROMS-SWAN coupled model. The COAWST version we're using is 3.8, and there are no issues when running ROMS or SWAN individually. However, when attempting the coupling, especially with #define WEC_VF, we are encountering the following message.

For your information, we had no problem running Rip Current example case with cpp WEC_VF on.

Can anyone lead us in fixing this issue?

Thank you!

-Joonho

coawst_error_02

jcwarner-usgs commented 8 months ago

can you send to me your *.h file

ocean0510 commented 8 months ago

Hello Warner,

I am attaching all the file related with the case.

Thank you. WEC error (COAWSTv3.8).zip

jcwarner-usgs commented 8 months ago

ok i fixed this. It had to deal with a string length to declare what variables are being transferred. We updated the code to include a new stokes computation, and that needs lots of vars to be exchanged. I updated waves_coupler.ftn and mct_roms_swan.h. can you do a git pull and try again?

ocean0510 commented 8 months ago

Absolutely. I will download it, try to compile them and run. Thank you, John.

ocean0510 commented 8 months ago

Thank you John.

Now the model works very well.

We had an issue when we turn on WEC_VF(model ran without problem without WEC_VF). Modified code from you, worked very well and now I can see the difference clearly. Thank you again for your work.

All the best, -Joonho

WEC_VF off WECVF_off

WEC_VF on WECVF_on

jcwarner-usgs commented 8 months ago

nice !