search

DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
198 stars 168 forks source link

hidtmgen product version #1383

Closed ascbot closed 5 years ago

ascbot commented 5 years ago

Author Name: Tammy Becker (Tammy Becker)

Original Assignee: Jean Backer

External Post: https://isis.astrogeology.usgs.gov/IsisSupport/index.php/topic,3401.0.html

Original Post Date: 20Feb2012

Description: Hello, I'm probably the only person using hidtmgen (so far), so I hope this support forum is the right place to submit a bug report/change request.
Thanks, Sarah

hidtmgen_MSL_TRAVERSE_GAP_1.pvl

DATA_SET_ID = "MRO-M-HIRISE-5-DTM-V1.0" DATA_SET_NAME = "MRO MARS HIGH RESOLUTION IMAGING SCIENCE EXPERIMENT DTM V1.0" PRODUCER_INSTITUTION_NAME = "UNIVERSITY OF ARIZONA" PRODUCER_ID = "UA" PRODUCER_FULL_NAME = "ALFRED MCEWEN, USGS-ASTROGEOLOGY " PRODUCT_VERSION_ID = "2.0" SOFTWARE_NAME = "SOCET SET 5.5.0" PRODUCING_INSTITUTION = "U" END

Output in print.prt file: Object = hidtmgen IsisVersion = "3.2.1 | 2010-11-05" ProgramVersion = 2010-12-01 ProgramPath = /apps/opt/usgs/isis3.Linux.x86_64/bin ExecutionDateTime = 2012-01-20T14:58:49 HostName = pnode03 UserName = smattson Description = "Generate PDS products from a DTM and four orthographic images."

Group = UserParameters DTM = DEM_1m_MSL_Traverse_Gap_1_isis3_forPDS.cub ORTHO1 = PSP_001488_1750_1m_o_isis3_forPDS.cub ORTHO2 = PSP_001488_1750_25cm_o_isis3_forPDS.cub ORTHO3 = PSP_001752_1750_1m_o_isis3_forPDS.cub ORTHO4 = PSP_001752_1750_25cm_o_isis3_forPDS.cub DEFAULTNAMES = true OUTPUTDIR = ./ PARAMSPVL = hidtmgen_MSL_TRAVERSE_GAP_1.pvl PRODUCER_FULL_NAME = "From parameters pvl file" RATIONALE_DESC = "Layered outcrop in Gale Crater" PRODUCT_VERSION_ID = 1.0 DTMBITTYPE = 32BIT NULL = true LRS = false LIS = false HIS = false HRS = false ORTHOBITTYPE = 8BIT ONULL = true OLRS = false OLIS = false OHIS = false OHRS = false ENDIAN = LSB End_Group

Group = Accounting ConnectTime = 00:03:15.0 CpuTime = 00:01:11.5 End_Group End_Object

ascbot commented 5 years ago

Original Redmine Comment Author Name: Debbie Cook (Debbie Cook) Original Date: 2013-03-26T01:56:26Z

The problem keyword, PRODUCT_VERSION_ID, doesn't seem to be included in the read of the paramspvl file. I would recommend adding it to the default paramspvl file and setting the default value to "from parameter pvl file" (see parameter PRODUCER_FULL_NAME for example). Then it can be handled in the same way as PRODUCER_FULL_NAME. Use ui.WasEntered(PRODUCT_VERSION_ID) to determine if the user entered a value in the gui. Otherwise read from the paramspvl file.

I noticed a typo in the xml documentation Under the list of items in the description of the parameter, PARAMSPVL, 

        <li>PRODUCTING_INSTITUION</li>

should be corrected to 

        <li>PRODUCING_INSTITUION</li>
ascbot commented 5 years ago

Original Redmine Comment Author Name: Tammy Becker (Tammy Becker) Original Date: 2013-05-22T19:30:29Z

Changed triage priority from 3 to 8 to reflect the importance by the team for a fix (As confirmed through Paul Geissler after talking with Rod Heyd).
Though, this issue will be covered by HiRise project; not isis-support. This application impacts the HiRise productivity.

ascbot commented 5 years ago

Original Redmine Comment Author Name: Jean Backer (Jean Backer) Original Date: 2013-09-11T21:47:40Z

I have added the following emails for reference.

============================================================================================================================================================================= Sent August 27, 2013

Hi Sarah,

I have fixed the bugs in hidtmgen output labels. (Below this message is a description of the changes.) These modifications should appear in our next release of ISIS (scheduled for January). Please let me know if you have any questions or concerns about these issues. If the modifications do address the bugs to your satisfaction, I would appreciate it if you could let me know so that I can close the support board request.

Thanks, Jeannie

For the SOURCE_PRODUCT_ID issue, this keyword value should now appear in parentheses rather than quotes. For the PRODUCT_VERSION_ID issue, this keyword has been added to the default file for the PARAMSPVL parameter since the documentation indicates that this is a required keyword in this file. It will now be treated the same as PRODUCER_FULL_NAME. By default, the value for this keyword will be taken from the PARAMSPVL. However, if the user enters a value for the SOURCE_PRODUCT_ID parameter of the program, the user-entered value will be used.

Below is a sample of the output label from two runs of the program: 1) In this case, the user does not enter product_version_id, so it's read from the paramspvl file. Also, notice the source_product_id has () instead of ""

parameters.pvl: DATA_SET_ID = "DataSetIdFromParamsPvl" DATA_SET_NAME = "Data Set Name From PARAMSPVL" PRODUCER_INSTITUTION_NAME = "Producer Institution Name from PARAMSPVL" PRODUCER_ID = "Producer Id from PARAMSPVL" PRODUCER_FULL_NAME = "Producer Full Name from PARAMSPVL" PRODUCT_VERSION_ID = "12.0" SOFTWARE_NAME = "Software Name from PARAMSPVL" PRODUCING_INSTITUTION = "Z" END

command hidtmgen dtm=dtm.cub ortho1=ortho1.cub ortho2=ortho2.cub ortho3=ortho3.cub ortho4=ortho4.cub outputdir=output paramspvl=parameters.pvl rationale_desc=rationale

output label PDS_VERSION_ID = PDS3

/ File format and length / RECORD_TYPE = FIXED_LENGTH RECORD_BYTES = 247 FILE_RECORDS = 247 ^IMAGE = 15

/ Identification Information / DATA_SET_ID = "DataSetIdFromParamsPvl" DATA_SET_NAME = "Data Set Name From PARAMSPVL" PRODUCER_INSTITUTION_NAME = "Producer Institution Name from PARAMSPVL" PRODUCER_ID = "Producer Id from PARAMSPVL" PRODUCER_FULL_NAME = "Producer Full Name from PARAMSPVL" PRODUCT_ID = "DT1PA_009404_2635_010221_2635_Z12" PRODUCT_VERSION_ID = "12.0" INSTRUMENT_HOST_NAME = "MARS RECONNAISSANCE ORBITER" INSTRUMENT_HOST_ID = "MRO" INSTRUMENT_NAME = "HIGH RESOLUTION IMAGING SCIENCE EXPERIMENT" INSTRUMENT_ID = "HIRISE" TARGET_NAME = "MARS" SOURCE_PRODUCT_ID = (PSP_009404_2635, PSP_010221_2635) RATIONALE_DESC = "Rationale" SOFTWARE_NAME = "Software Name from PARAMSPVL"

2) In this case, the user enters a product_version_id, producer_full_name, and source_product_id, so the program outputs these user-entered values to the labels rather than reading product_version_id and producer_full_name from paramspvl and creating the source_product_id from the file names.

parameters.pvl is same as above

command hidtmgen dtm=dtm.cub ortho1=ortho1.cub ortho2=ortho2.cub ortho3=ortho3.cub ortho4=ortho4.cub outputdir=output paramspvl=parameters.pvl rationale_desc=rationale producer_full_name="producer full name user entered" product_version_id=3.0 source_product_id=sourceid

output label PDS_VERSION_ID = PDS3

/ File format and length / RECORD_TYPE = FIXED_LENGTH RECORD_BYTES = 288 FILE_RECORDS = 220 ^IMAGE = 16

/ Identification Information / DATA_SET_ID = "DataSetIdFromParamsPvl" DATA_SET_NAME = "Data Set Name From PARAMSPVL" PRODUCER_INSTITUTION_NAME = "Producer Institution Name from PARAMSPVL" PRODUCER_ID = "Producer Id from PARAMSPVL" PRODUCER_FULL_NAME = "Producer Full Name User Entered" PRODUCT_ID = "DtmProduct" PRODUCT_VERSION_ID = "3.0" INSTRUMENT_HOST_NAME = "MARS RECONNAISSANCE ORBITER" INSTRUMENT_HOST_ID = "MRO" INSTRUMENT_NAME = "HIGH RESOLUTION IMAGING SCIENCE EXPERIMENT" INSTRUMENT_ID = "HIRISE" TARGET_NAME = "MARS" SOURCE_PRODUCT_ID = SourceId RATIONALE_DESC = "Rationale" SOFTWARE_NAME = "Software Name from PARAMSPVL"

============================================================================================================================================================================= Sent August 29, 2013

Hi Jeannie,

Thanks for making these fixes.

The first example looks fine. I'm not sure where the SOURCE_PRODUCT_ID values are coming from, since they are not specified in the command line. But it's good they are in parentheses now in the label!

In the second example, the SOURCE_PRODUCT_ID is specified on the command line, which is how we typically run hidtmgen, but in the label, it appears without () or "" in the label. Is that expected? The perl snippet for that input argument in my script is

source_product_id=$Stereo_1,$Stereo_2

Will this still work?

Is there any way we can get a pre-release version of this to test here before it goes out in the official release in January?

On the topic of ISIS releases, is the schedule going to be updates about every six months now? Just curious.

Thank you again for addressing these issues.

Best, Sarah

============================================================================================================================================================================= Sent August 29, 2013

Hi Sarah, Thanks for the quick response.

We are still on a quarterly release schedule, but the October release has been cancelled since there were no changes to Isis to release. Stuart will get back to you about getting a pre-release when he has had a chance to discuss this with Laz.

Here are the answers to your questions about the program.

If DEFAULTNAMES=true, the user does not enter a source product ID. In this case, it is generated by the program using the first 15 characters of ORTHO1 and ORTHO3.

The program does not add parentheses to user-entered keywords. If the user is entering a keyword and want the value to be an array or set, then the string passed into the program should have the appropriate braces.

gui - no parenthesis escaping needed SOURCE_PRODUCT_ID (id1, id2)

command line - the value should be quoted and the first paranthesis should be escaped with a backslash. If the backslash is missing, the second value will not be written to the labels The backslash is not needed for [ or {. source_product_id= "( id1, id2 )"

If you are running scripts, you will need to type in the parentheses as required for your scripting language.

Jeannie

============================================================================================================================================================================= Sent August 29, 2013

Hi Jeannie,

Thank you for the clarification. Very helpful! I run hidtmgen with defaultnames=false, so I'll need to update my script to enter parentheses. Good to know!

Let us know when you find out about the pre-release for testing. I believe our system is set up for this now. Rod Heyd and our Sys group cc'd here in case there are technical issues regarding this.

Thank you again, Sarah

ascbot commented 5 years ago

Original Redmine Comment Author Name: Tammy Becker (Tammy Becker) Original Date: 2013-09-13T22:21:41Z

Will deliver a pre-release version of ISIS to the Hirise team to test. If the team encounters an issue with this, we can reopen this ticket.