documentation for pds2isis

ascbot commented 5 years ago

Author Name: Trent Hare (Trent Hare)

Original Assignee: Trent Hare

We need a good place either on the pds2isis page or ISIS help docs which lists this change and the use and importance of the configuration file: $ISIS3DATA/base/translations/pdsProjectionLineSampToXY.def The current mapping in this file might be a table on that page (or at least this file accessible to others).

This should also discuss that ISIS defines the top left corner as 0.5 line 0.5 sample as stated here: https://isis.astrogeology.usgs.gov/documents/LabelDictionary/LabelDictionary.html This implies the center of the top-left pixel is 1,1

The abstract should be pointed to as a reference (which can help explain our current understanding for the offset values in PDS): http://www.hou.usra.edu/meetings/lpsc2016/pdf/1812.pdf

ascbot commented 5 years ago

Original Redmine Comment Author Name: John Bonn (John Bonn) Original Date: 2017-05-22T22:44:07Z

Added the following text to the /usgs/cpkgs/isis3/data/base/translations/README.txt file:

pdsProjectionLineSampToXY_V2.def replaces pdsProjectionLineSampToXY.def for Isis version 3.5.1 and above. This has the corrected PDS offset data to fix bug m02244 "Pixel (Line/Sample) Projection Offset Issue".

The following header has been been added to pdsProjectionLineSampToXY.def


#
#
1. ******** THIS FILE HAS BEEN DEPRECATED AS OF VERSION 3.5.1 OF ISIS  ********
#
1. it has been replaced by pdsProjectionLineSampToXY_V2.def
#
#

Note we still need real documentation on this.

ascbot commented 5 years ago

Original Redmine Comment Author Name: Trent Hare (Trent Hare) Original Date: 2017-06-26T04:51:20Z

The current version of this file now only contains PDS3 archives that require label overrides to correct for known issues. It will be updated if needed. It is here just for reference. Note that ISIS2 files are listed here since they imported into ISIS3 using the same pds2isis routine and do not use the same PDS3 mults or offsets.

1.  This file is used by the ProcessImportPds class to define the offset and
1.  multiplication factors to convert between  sample/line and x/y.
#
1.  The Keyword defines which keyword is searched for in the pds file.  The
1.  Pattern is then used to match the value in the defined keyword.  If there
1.  is a match,  the given values are used.
1.  The defaults used in ProcessImportPds are:
1.      xMult  =  -1.0
1.      yMult  =   1.0
1.      xOff   =  0.5
1.      yOff   =  0.5
#
1. Equations used are
#
1.     upperLeftX = xmult * (sampleOffset + xOff) * PixelResolution
1.     upperLeftY = ymult * (lineOffset + yOff) * PixelResolution
#
1.  Anytime a new group is added to this file, all 6 keywords need to be
1.  defined (Keyword,Pattern,xMult,yMult,xOff,yOff).
#
1.  @history 2007-04-10  Tracie Sucharski, Original version with
1.                       Isis2 definitions.
1.  @history 2008-06-10  Jeff Anderson, Fixed Magellan to be more specific to
1.                       FMAPS and MIDRS
1.  @history 2008-10-01  Steven Lambright, Fixed Isis 2 offsets, fixed cassini radars
1.                       Keyword/Pattern values. Commented and fixed MIDR offsets.
1.  @history 2011-01-26  Janet Barrett, Added support for Kaguya Terrain Camera
1.                       (TC_MAP)
1.  @history 2011-11-16  Jeff Anderson, Added support for LROC data
1.  @history 2012-03-04  Janet Barrett, Added support for Kaguya Terrain Camera
1.                       Ortho data (TCO_MAP)
1.  @history 2017-05-25  J Bonn  KAGUYA TERRAIN CAMERA and  KAGUYA TERRAIN CAMERA
1.                       ORTHO entires to +0.5 yoff,yoff per ticket m04506
1.  @history 2017-05-26  T Hare  With ticket m02244 fix, removed entires that no
1.                       longer need an override including: CHANDRAYAAN and LRO
1.                       MINIRF, CASSINI RADAR, LROC PDS RDR, MESSENGER DEM, and
1.                       HRSC PDS products. Added new entry for MGS MOLA

Object = ProjectionOffsetMults
  #  MAGELLAN - MIDR
  #  Must stay above ISIS2
  #  Magellan MIDR file labels were converted from VICAR labels to PDS
  #   labels, and in this conversion the sample/line offsets were rounded
  #   to whole numbers; subpixel accuracy was lost. Because of this, we'll
  #   never exactly match the latitude/longitude but we can be close.
  Group = Selection
    Keyword = "DATA_SET_ID"
    Pattern = "MGN-V-RDRS-5-MIDR"
    xMult   = -1.0
    yMult   = 1.0
    xOff    = -0.5
    yOff    = 1.0
  End_Group

  # VIKING ORBITER
  Group = Selection
    Keyword = "DATA_SET_ID"
    Pattern = "VO1/VO2-M-VIS-5-DIM-V1.0"
    xMult = -1.0
    yMult =  1.0
    xOff = -1.0
    yOff = -1.0
  End_Group

  #  ISIS2
  Group = Selection
    Keyword = "CCSD3ZF0000100000001NJPL3IF0PDS200000001"
    Pattern = "SFDU_LABEL"
    xMult   = 1.0
    yMult   = -1.0
    xOff    = -0.5
    yOff    = -0.5
  End_Group

 #  MAGELLAN - FMAP
  Group = Selection
    Keyword = "DATA_SET_ID"
    Pattern = "MGN-V-RDRS-5-DIM"
    xMult   = 1.0
    yMult   = -1.0
    xOff    = 1.5
    yOff    = 1.5
  End_Group

  #  KAGUYA TERRAIN CAMERA ORTHO
  Group = Selection
    Keyword = "DATA_SET_ID"
    Pattern = "TCO_MAP"
    xMult   = 1.0
    yMult   = 1.0
    xOff    = 0.5
    yOff    = 0.5
  End_Group

  #  KAGUYA TERRAIN CAMERA
  Group = Selection
    Keyword = "DATA_SET_ID"
    Pattern = "TC_MAP"
    xMult   = 1.0
    yMult   = 1.0
    xOff    = 0.5
    yOff    = 0.5
  End_Group

  # MOLA MEGDR
  Group = Selection
    Keyword = "DATA_SET_ID"
    Pattern = "MGS-M-MOLA-5-MEGDR-L3-V1.0"
    xMult = -1.0
    yMult = 1.0
    xOff = -0.5
    yOff = -0.5
  End_Group

End_Object

ascbot commented 5 years ago

Original Redmine Comment Author Name: Trent Hare (Trent Hare) Original Date: 2017-06-30T16:44:25Z

Still can't attach anything here but here is a link to the current version to document the PDS/ISIS3 Pixel Offset resolution. I assume this will go in the release note for 3.5.1 and maybe an ISIS WIKI page or... Comments or corrections are still welcome.

https://www.dropbox.com/s/ui19p8vq3wbmdi5/ISIS3_PDS3_Offset_Resolution_June2017_v2.docx?dl=0

DOI-USGS / ISIS3

documentation for pds2isis #2302