DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
195 stars 166 forks source link

pds2isis can't process a particular pds3 file #2416

Closed ascbot closed 5 years ago

ascbot commented 5 years ago

Author Name: Kaj Williams (Kaj Williams)

Original Assignee: Summer Stapleton


Download two files: http://pds-geosciences.wustl.edu/mgn/mgn-v-rss-5-gravity-l2-v1/mg_5201/topo/topogrd.dat http://pds-geosciences.wustl.edu/mgn/mgn-v-rss-5-gravity-l2-v1/mg_5201/topo/topogrd.lbl

Then attempt a pds2isis command: pds2isis FROM=topogrd.lbl TO=magellantopo.cub

It fails with the following message: I/O ERROR Unknown label type in [topogrd.lbl].

As noted, pds2isis should not be able to process this PDS table file, but a better error message would be appropriate.

Suggestion: Add a check in ProcessImportPDS to throw a stacked IError when it can't find "Image", or "SpectralCube"

ascbot commented 5 years ago

Original Redmine Comment Author Name: Robert Sucharski (Robert Sucharski) Original Date: 2017-05-25T17:35:16Z


The file listed in the post is not image data so ISIS cannot open the file. I was able to find an image file at, http://pds-geosciences.wustl.edu/mgn/mgn-v-rss-5-gravity-l2-v1/mg_5201/images/topogrd.*(lbl and img), that pds2isis was able to open and create an ISIS cube, however mapping keywords were not added to the labels(maybe having problems with "MAP_SCALE = "N/A").

ascbot commented 5 years ago

Original Redmine Comment Author Name: Stuart Sides (@scsides) Original Date: 2017-11-22T20:21:07Z


Find the location of the reported error, and add:

It is possible the label file does not describe an image product (IMAGE, CUBE, or SPECTRALCUBE).

ascbot commented 5 years ago

Original Redmine Comment Author Name: Summer Stapleton (Summer Stapleton) Original Date: 2017-11-26T21:12:18Z


Changes in /work/project/isis/latest/m04883

This change is in ProcessImportPds.cpp, which is only used in the many 2isis applications, with the exception of pds2hideal.cpp and a kaguyasp2ascii.cpp, but confirmed that neither of these apps make a call to the affected method, so should not affect these applications.

ascbot commented 5 years ago

Original Redmine Comment Author Name: Kaj Williams (Kaj Williams) Original Date: 2017-12-04T15:16:09Z


Can't test this yet: when I run this from the command line on prog25, I get the following error:

[kewilliams@prog25 pds2isis]$ ./pds2isis FROM= /home/kewilliams/test/topogrd.lbl TO= /home/kewilliams/test/magellantopo.cub ./pds2isis: error while loading shared libraries: libisis3.5.2.so: cannot open shared object file: No such file or directory

ascbot commented 5 years ago

Original Redmine Comment Author Name: Summer Stapleton (Summer Stapleton) Original Date: 2017-12-11T18:47:02Z


Hi Kaj, I'm not sure why you would be getting that error. (Just checked it and I am getting the same thing.) I will look into it. I just confirmed that you should still be able to run pds2isis from isis root without any issues. (Note that this is without the "./" ) The changes I made will be testable from there.

ascbot commented 5 years ago

Original Redmine Comment Author Name: Kaj Williams (Kaj Williams) Original Date: 2017-12-14T15:09:59Z


Thanks, I now get the following: [kewilliams@prog25 ~/test]$ pds2isis FROM=topogrd.lbl TO=magellantopo.cub here? I/O ERROR Unknown label type in [topogrd.lbl]. It is possible the label filedoes not describe an image. [kewilliams@prog25 ~/test]$

Question: What does the "here?" mean in this context? Also there seems to be a space missing between "file" and "does".

ascbot commented 5 years ago

Original Redmine Comment Author Name: Summer Stapleton (Summer Stapleton) Original Date: 2017-12-19T00:23:57Z


Removed extraneous output and modified error message. Sorry about that!

ascbot commented 5 years ago

Original Redmine Comment Author Name: Kaj Williams (Kaj Williams) Original Date: 2017-12-19T17:29:45Z


Looks good, thanks.