search

DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
195 stars 166 forks source link

Kaguya SP 2C v3 detached label breaks `kaguyasp2isis` #3196

Closed jlaura closed 3 years ago

jlaura commented 5 years ago

Description
This enhancement is a direct result of #3143. The data being used have a detached label. The reader is written for an attached label. Therefore, we need to be able to ingest

Example
kaguyasp2isis FROM=<my_new_v3.spc> FROMLABEL=<my_new_v3.lbl>

Example Data Data can be accessed from the SELENE Data Archive: http://darts.isas.jaxa.jp/planet/pdap/selene/product_search.html

The Data set ID (first form box) is SLN-L-SP-4-LEVEL2C-V3.0. The Data set name is SELENE MOON SP 4 LEVEL2C V3.0. Any of the data here can be used to test.

jlaura commented 5 years ago

I just fixed this in plio. In addition to passing the header, it looks like the label format has slightly changed.

kberryUSGS commented 5 years ago

@jlaura If you fixed this in plio, is the solution to point people to plio, to fix this app in ISIS or both? I believe this is the application that outputs a tab-delimited text file, not a cube, so in some sense it's not really "2isis"

kberryUSGS commented 5 years ago

I thought kaguyasp2isis had been removed and replaced with kaguyasp2ascii. It looks like the mv didn't happen and now kaguyasp2isis is just an out-of-date / less functional version of kaguyasp2ascii. Maybe fixing this should be it's own ticket, I'm not sure.

geokramer commented 4 years ago

Description This enhancement is a direct result of #3143. The data being used have a detached label. The reader is written for an attached label. Therefore, we need to be able to ingest

Example kaguyasp2isis FROM=<my_new_v3.spc> FROMLABEL=<my_new_v3.lbl>

Example Data Data can be accessed from the SELENE Data Archive: http://darts.isas.jaxa.jp/planet/pdap/selene/product_search.html

The Data set ID (first form box) is SLN-L-SP-4-LEVEL2C-V3.0. The Data set name is SELENE MOON SP 4 LEVEL2C V3.0. Any of the data here can be used to test.

I am having the same problem with kaguyasp2ascii ("not a valid Kaguya Spectral Profiler file"). However, the example fix does not work for me. I get this error: "Unknown parameter [FROMLABEL]"

I just installed isis3 using miniconda. I am somewhat experienced using isis, but not before through Github. And I really have zero programming skills (a bit in IDL). What am I not understanding? Am I supposed to install "Reading_Kaguya_Level2C_Data.ipynb" somewhere? Will that fix it?

Thank you for your patience with me.

jessemapel commented 4 years ago

@geokramer For right now, we are not supporting detatched Kaguya SP 2c v3 labels in ISIS. As a work around you can use the PLIO package to read in and work with the data. @jlaura may be able to point you to some examples.

geokramer commented 4 years ago

@jlaura I tried to install plio, as per @jessemapel , using these instructions: https://github.com/USGS-Astrogeology/plio to see if I could figure it out. That failed utterly, returning this error:

UnsatisfiableError: The following specifications were found to be incompatible with the existing python installation in your environment:

and complaining about having a too recent version of python installed. This was then followed by a frightening mess of text detailing specific incompatibilities.

As I wrote in the comment I posted above, I am really clueless here. I'm not sure how to tell conda to change the python version to a 3.5, or if that is even necessary. Or does it have something to do with me installing Miniconda instead of Anaconda? Please help so I can start working with SP data?

geokramer commented 4 years ago

@jlaura I think I have successfully installed plio. I don't know how to test it?

jlaura commented 4 years ago

@geokramer Awesome. I would run the following from a terminal: python -c "import plio;print(plio)"

When I run that I see the installation directory where plio is installed:

➜ python -c "import plio;print(plio)"
<module 'plio' from '/Users/jlaura-pr/github/plio/plio/__init__.py'>

Let me know if that works for you. If it does, then you should be good to try the linked Jupiter notebook where we use a detached label.

ascbot commented 4 years ago

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last eleven months! If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

In one month I will close this issue on it's birthday unless it has some activity.

ascbot commented 3 years ago

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last eleven months! If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

In one month I will close this issue on it's birthday unless it has some activity.

ascbot commented 3 years ago

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last eleven months! If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

In one month I will close this issue on it's birthday unless it has some activity.

ascbot commented 3 years ago

I am a bot that cleans up old issues that do not have activity.

Happy Birthday to this issue! :birthday:

Unfortunately, this issue has not received much attention in the last 12 months. Therefore, I am going to close it. Please feel free to reopen this issue or open a new issue sometime in the future. If this issue is a bug report, please check that the issue still exists in our newest version before reopening.