search

DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
198 stars 168 forks source link

CTX images are using linear position interpolation instead of hermite #3928

Closed jessemapel closed 4 years ago

jessemapel commented 4 years ago

ISIS version(s) affected: 4.1.0 (likely 4.0) and later

Description

When spiceinit'd with ISIS 4.1.0, some CTX images are using linear position interpolation instead of cubic hermite splines. This is causing errors on the order of a few meters vertically. Currently we've seen this with J03_045994_1986_XN_18N282W and J03_046060_1986_XN_18N282W so far. It is likely occurring in more images.

How to reproduce

Spiceinit the cube with ISIS3 and then spiceinit the cube with ISIS4. The InstrumentPosition CacheType will be HermiteSpline under ISIS3 and Linear under ISIS4.

Possible Solution

This is likely caused by the cache being significantly smaller when ALE creates it compared to ISIS. Additional context

kberryUSGS commented 4 years ago

This is happening with HRSC images as well, and based on where this is happening in the code, I'd expect it to happen with any LineScanner in ISIS.

AndrewAnnex commented 4 years ago

@jessemapel can you confirm this issue is fixed as of 4.2.0, unfortunately Ames stereo is locked to 4.1.0 at the moment

jessemapel commented 4 years ago

Just tested and it is still failing. Putting this on the todo list for next week :(

jlaura commented 4 years ago

@jessemapel Is this on the list for this week or should I pull this as a candidate for the support sprint?

jessemapel commented 4 years ago

@jlaura Put it in for support at this point. I don't think we'll have time to get to it this week.

jessemapel commented 4 years ago

Okay, confirmed this is fixed, but it just missed the 4.2 code freeze by 1 day. So, this will be out in 4.2.1 and 4.3.0