search

DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
200 stars 169 forks source link

updating CART to a more recent version (1B00 and higher), ideally the latest "H" or soon "I". #4823

Open thareUSGS opened 2 years ago

thareUSGS commented 2 years ago

https://github.com/USGS-Astrogeology/ISIS3/blob/916d3fe1610c00c53723d1c603d4e73b9db82c41/isis/appdata/export/mappingGroup.tpl#L38

There was a breaking change in 2019 to replace the confusing and really non-sensical keywords "semi_major_radius" (and others). THe use of "semi_major_radius" implies "half of a half" by using "semi" and "radius" in the same name. Bad form.

These updated keywords also better align with previous uses in PDS: a_axis_radius -- usually called semi-major b_axis_radius -- only used in a triaxial definition (should almost always be the same as a_axis_radius *). c_axis_radius -- polar radius (or generally called semi-minor)

footnote * : actually setting a triaxial is not recommended for most all map projections (and users should default to an IAU-approved spherical mean radius). https://astrogeology.usgs.gov/groups/IAU-WGCCRE

Lastly, updating to a newer version, unfortunately, might force the need to reorder one or two attributes. Validation checks will find those.

github-actions[bot] commented 2 years ago

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

thareUSGS commented 1 year ago

This remains an important update for any PDS4 reader/writer.

github-actions[bot] commented 1 year ago

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

thareUSGS commented 1 year ago

This is still an important update. The original attribute names were deprecated (and oddly named). The update to a latter PDS 4 version will help.

github-actions[bot] commented 9 months ago

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

thareUSGS commented 3 months ago

Latest update has moved from PDS4 information model 1.B.0.0 to 1.M.0.0. Ideally picking up the latest version when PDS4 updates are addressed would be good. Note every 6 months there is a version update. Getting the latest version is not as important as the updates to the original breaking change in the PDS4 label which was updated in 2019 (from the original issue above).