DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
200 stars 168 forks source link

cam2map bullet ray tracing error #5291

Open lwellerastro opened 1 year ago

lwellerastro commented 1 year ago

ISIS version(s) affected: 7.1.0 onward; works under 7.0.0

Description
cam2map fails with the following error when attempting to project an image that was initialized using a DSK file as the shape model with bullet ray tracing:

  Group = Error
    Program = cam2map
    Class   = "PROGRAMMER ERROR"
    Code    = 3
    Message = "No hits in ray trace so no normal!"
    File    = BulletClosestRayCallback.cpp
    Line    = 190
  End_Group

No error is encountered when attempting the same under isis7.0.0.

How to reproduce
My data were recently reprocessed via isis8.0.0-RC1 and were spiced using the isis driver (source=isis) and a DSK file located under our projects area. For some reason versions of isis prior to and after this version pick up some version of the ale driver. I decided to stick with this version to avoid ale and have these MEX HRSC images be consistent with my MEX SRC images which don't pick up any ale driver no matter the version of isis (don't know why that is).

Simple processing can be replicated using the supplied files in my users area Isis3Tests/DSK/Cam2map/ directory, which includes a copy of the DSK file. In order to mimic my processing please use the supplied isis preference file which specifies bullet ray tracing. The ShapeModel group is commented out in my personal isisPreferences file for a variety of reasons, but use of bullet can be applied by including that information in the command line (see proc.scr in same directory/instructions below) for isis programs that are not interactive (qview, qnet, qmos). It is not necessary to use isis8.0.0-RC1 to pick up the isis spice driver since I have confirmed the error will occur for an image ingested and spiced under isis8.0.0LTS picking up the ale 0.9.1 driver.

hrsc2isis from=H0756_0000_ND2.IMG to=H0756_0000_ND2.lev0.cub -preference=IsisPreferences_Bullet
spiceinit from=H0756_0000_ND2.lev0.cub shape=user model=PHOBOS_K275_DLR_V02.BDS -preference=IsisPreferences_Bullet
cam2map from=H0756_0000_ND2.lev0.cub to=H0756_0000_ND2.lev2.cub map=simp_clon0.map pixres=map -preference=IsisPreferences_Bullet

Additional context
Running the same cam2map command under isis7.0.0 will generate a projected file (output is also included in my work directory):

cam2map from=H0756_0000_ND2.lev0.cub to=H0756_0000_ND2.Isis700.lev2.cub map=simp_clon0.map pixres=map -preference=IsisPreferences_Bullet

However, once projected, qview will produce the BulletClosestRayCallback error message when the cursor is anywhere on the target.

Further, this error only occurs for MEX HRSC images, not MEX SRC images that have the same processing and point to the same DSK model. SRC has no cam2map errors and once projected and loaded in qview does not produce any error/warning messages like the HRSC images.

lwellerastro commented 1 year ago

I want to point out that this is not the same error as reported in #5036, though the cause may be the same. I am realizing now that I did not encounter the problems outlined in 5036 for my newly processed images under iis8.0.0-RC1 because this version used the isis spice driver. The data reported in 5036 were processed under isis7.1.0-RC1 which used ale 0.8.7 and may have been the cause of the errors reported in that post.

Like post #5036, the errors I have encountered only occur with MEX HRSC images, not the MEX SRC images. Perhaps there is an issue with line scan data (HRSC) vs framing (SRC) or something about the camera HRSC camera model which is in conflict with intersect code.

github-actions[bot] commented 8 months ago

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

lwellerastro commented 8 months ago

This is still an issue

github-actions[bot] commented 1 month ago

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here