search

DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
195 stars 166 forks source link

Jigsaw documentation #5358

Open oleg-alexandrov opened 9 months ago

oleg-alexandrov commented 9 months ago

The documentation of the jigsaw tool at https://isis.astrogeology.usgs.gov/Application/presentation/Tabbed/jigsaw/jigsaw.html does not explain how the tool should be used.

It should have an example invocation, it should say what is the format of the list of cubes, how to prepare an input cnet, what are adjustable parameters, and how they should be passed to the tool.

lwellerastro commented 9 months ago

Hi @oleg-alexandrov, ISIS interactive software could certainly use better documentation (referring to your #5373 PR), but as you probably know, it's complicated to hit all the particulars since it can be extremely data set dependent.

This is not comprehensive and likely has bits and pieces out of date, but the Wiki has some PDF's covering basic aspects of all the q-related programs as well as jigsaw: https://github.com/DOI-USGS/ISIS3/wiki/ISIS_Demo . Maybe these could be pointed to as an intermediary until improved documentation can be supported.

I think jigsaw in particular can use help especially on how what settings should be used for type of camera and suggested starting uncertainties (sigmas). This would require a bit of effort though.

oleg-alexandrov commented 9 months ago

Thanks. I took a look. In the meantime I added a little paragraph to jigsaw.xml describing how to create the initial control network (as part of https://github.com/DOI-USGS/ISIS3/pull/5373).

github-actions[bot] commented 3 months ago

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

Kelvinrr commented 3 months ago

bump it, this is important

oleg-alexandrov commented 3 months ago

ASP's has its own little jigsaw tutorial. It has been there for a while, but I verified that it works and touched it up recently. See https://stereopipeline.readthedocs.io/en/latest/bundle_adjustment.html#tutorial-processing-mars-orbital-camera-images.

Would be nice to have at least the most basic commands in. Better have something quick soon, than something detailed after a long time.

BTW, there appear some examples in other tabs of the jigsaw doc, but those are very easy to miss as they appear grayed out.

Ideally a very simple example would be in the main doc, in its own section, right after the intro, which outlines also how to create .lis files and creation of feature matches with autoseed, etc. Then, that example could have links to the other tabs for more advanced usage.

AustinSanders commented 2 months ago

There's a new document on the docs repo that covers the basics of jigsaw / bundle adjustment. It includes everything from data download, .lis file creation, footprintinit, findimageoverlaps, autoseed, and bundle adjustment.

oleg-alexandrov commented 2 months ago

The problem is that users are directed to the barebone older document rather than this better newer document.

Maybe the older document should be wiped and replaced with a link to the new document. The old pages also look quaint and awkward in the browser.