search

DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
198 stars 168 forks source link

ISIS 8.0.3 is not compatible with PDAL #5519

Open oleg-alexandrov opened 4 months ago

oleg-alexandrov commented 4 months ago

ISIS version(s) affected: 8.0.3

Description

ISIS 8.0.3 (also ISIS 8.0.1) cannot be installed together with PDAL 2.6.0 in a conda environment. It appears that ISIS insists on openssl=1.1.1w while PDAL wants openssl >=3.1.4.

Similar issues came up before. It would be good if PDAL is an explicit dependency of ISIS, as otherwise it is not possible to guarantee the dependencies line up.

Kelvinrr commented 4 months ago

Are you sure the problem is openSSL?

It should be pinned to >=3.1.2,<4.0a0

Installing locally, it seemed to be using 3.1.6

(isis8.0.3) igswza281l2305:BTree krodriguez$ conda list openssl
# packages in environment at /Users/krodriguez/miniforge3/envs/isis8.0.3:
#
# Name                    Version                   Build  Channel
openssl                   3.1.6                h87427d6_0    conda-forge

That being said it doesn't solve the problem, PDAL is definitely not able to be installed. There were quite a bit of changes between 8.0 and 8.0.2 to the recipe so this maybe came in at an older version. @oleg-alexandrov do you know if 8.0 and 8.0.2 have the same issue? Will help track down the offending change.

oleg-alexandrov commented 4 months ago

Here's what i get:

(isis8.0.3) $ conda list | grep -E "isis|ssl"

packages in environment at /home/oalexan1/miniconda3/envs/isis8.0.3:

isis 8.0.3 np126_0 usgs-astrogeology openssl 1.1.1w hd590300_0 conda-forge

This is for Linux, not Mac.

Can you try to see if it works for Linux to install PDAL 2.6 in your own env?

On Sun, Jun 16, 2024 at 6:59 AM Kelvin Rodriguez @.***> wrote:

Are you sure the problem is openSSL?

It should be pinned to >=3.1.2,<4.0a0 https://github.com/DOI-USGS/ISIS3/blob/dev/recipe/meta.yaml#L94C13-L94C28

Installing locally, it seemed to be using 3.1.6

(isis8.0.3) igswza281l2305:BTree krodriguez$ conda list openssl# packages in environment at /Users/krodriguez/miniforge3/envs/isis8.0.3:## Name Version Build Channel openssl 3.1.6 h87427d6_0 conda-forge

That being said it doesn't solve the problem, PDAL is definitely not able to be installed.

— Reply to this email directly, view it on GitHub https://github.com/DOI-USGS/ISIS3/issues/5519#issuecomment-2171675118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKDU3DRYHUQBEIZE5K2TA3ZHWK3NAVCNFSM6AAAAABJK2S3T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRGY3TKMJRHA . You are receiving this because you authored the thread.Message ID: @.***>

acpaquette commented 3 months ago

@oleg-alexandrov To get a little more info on this. To get PDAL installed along side ISIS we have to update a number of dependencies. This effort has been on going into 8.2 RCX and has resulted in a number of growing pains. Currently, you can install PDAL 2.5.6 along side ISIS 8.2 RC2 which I am working on releasing.

Given the mass dependency changes needed to get things rolling with qt 5.15 and others, it's best if it stays in the feature releases for now and will make its way into 9.0. I don't believe any of the updates have resulted in API breaking changes but it is a potential issue. In this regard, 8.0.X stability is likely more important over making sure it installs with these other packages.

For future releases we are going to update most of the ISIS deps to install easier along side ISIS. As I mentioned 9.0 should be able to install along side at least PDAL 2.5.6 as the 8.2 RC2 will be.