DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
200 stars 168 forks source link

Fixes qmos segfaults #5556

Closed amystamile-usgs closed 3 months ago

amystamile-usgs commented 3 months ago

geos 3.12 switches up the order of polygon coordinates. This caused issues with PolygonTools::FixSeam's algorithm. Running normalized reorganizes the polygons into normal form.

Description

Related Issue

closes #5539

How Has This Been Validated?

Types of changes

Checklist:

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

amystamile-usgs commented 3 months ago

The following tests FAILED:

4966 | 538 - isis2gml_app_test_case01 (Failed) 4967 | 539 - isis2gml_app_test_case02 (Failed) 4968 | 540 - isis2gml_app_test_lincsinc (Failed)

Will look into these today.

amystamile-usgs commented 3 months ago

@acpaquette I confirmed that the tests are expected failures due to change in order of polygon coordinates. I checked that the footprints are identical to the current truthdata. I was gonna convert isis2gml to gtests but this would require having to set up an xml reader. For now, I can just update the truth data.