The explode application has been refactored to be callable and Makefile test converted to a gtest.

kledmundson commented 3 months ago

Description

The explode application has been refactored to be callable. The one existing Makefile test has been converted to a gtest. The Makefile test has been removed. One small (193K) test cube has been added to isis/tests/data/explode.

How Has This Been Validated?

The one ISIS Makefile test has been replaced with the gtest ExplodeCase01.

Results of ctest suite...

ctest -R Explode --output-on-failure

Test project /Users/kledmundson/ISISDev/explode/Jul192024/ISIS3/build Start 1856: Explode.ExplodeCase01 1/1 Test #1856: Explode.ExplodeCase01 ............ Passed 0.71 sec

100% tests passed, 0 tests failed out of 1

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation change (update to the documentation; no code change)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

[X] I have read and agree to abide by the Code of Conduct
[X] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] I have added myself to the .zenodo.json document.
[X] I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

[X] I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

kledmundson commented 3 months ago

I’ll have a look. Thanks.

On Thu, Jul 25, 2024 at 08:05 Amy Stamile @.***> wrote:

@.**** commented on this pull request.

In isis/tests/FunctionalTestsExplode.cpp https://github.com/DOI-USGS/ISIS3/pull/5558#discussion_r1691623988:

+using namespace Isis; + +static QString APP_XML = FileName("$ISISROOT/bin/xml/explode.xml").expanded(); + +/**

Explode Case01 Test

*

Export (i.e. Explode) each band of an input

cube with two bands into individual cubes.

*

INPUT: isisTruth.cub

*

OUTPUT: 1) explTruth1.band0001.cub

2) explTruth1.band0002.cub

*/ +TEST(Explode, ExplodeCase01) {

Is it possible to use the DefaultCube test fixture instead of including the isisTruth.cub?

— Reply to this email directly, view it on GitHub https://github.com/DOI-USGS/ISIS3/pull/5558#pullrequestreview-2199591302, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUGSUULC6XFAOQQZFQQCLLZOEH4JAVCNFSM6AAAAABLNCMPLOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJZGU4TCMZQGI . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5558".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

DOI-USGS / ISIS3