DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.

https://isis.astrogeology.usgs.gov

Other

200 stars 168 forks source link

Testing Valueless PVL Keyword Issues #5573

Closed acpaquette closed 1 day ago

acpaquette commented 3 months ago

Description

Account for valueless PVL keywords that are not reserved keywords. This change is to test how much of ISIS breaks when we account for valueless PVL keywords

Related Issue

5566

How Has This Been Validated?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation change (update to the documentation; no code change)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

[x] I have read and agree to abide by the Code of Conduct
[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] I have added myself to the .zenodo.json document.
[ ] I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

[x] I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

acpaquette commented 3 months ago

All possible tests are passing on this PR. Other tests would need to have something in the data area or test data area updated. Here are the following tests that will have some data element updated:

411 - csv2table_app_test_Label (Failed)
487 - footprintmerge_app_test_360Boundary (Failed)
488 - footprintmerge_app_test_default (Failed)
577 - isisminer_app_test_pdstableformat (Failed)
582 - isisminer_app_test_stereopair (Failed)
583 - isisminer_app_test_stereopair2 (Failed)
1046 - hicalbeta_app_test_default (Failed)
1047 - hicalbeta_app_test_dnpermicrosecs (Failed)
1048 - hicalbeta_app_test_dns (Failed)
1049 - hicalproc_app_test_default (Failed)
1050 - hicalproc_app_test_destripe (Failed)
1051 - hicalproc_app_test_furrows (Failed)
1888 - HicalTest.Default (Failed)
1889 - HicalTest.Dns (Failed)
1890 - HicalTest.DnsPerMicrosecond (Failed)

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

github-actions[bot] commented 3 months ago

The build and test suite have started for your pull request. View build logs for results.

AustinSanders commented 3 days ago

Looks like this is failing some tests.

     78 - isis_unit_test_Cube (Failed)
    327 - isis_unit_test_XmlToPvlTranslationManager (Failed)
    411 - csv2table_app_test_Label (Failed)
    435 - cubeit_app_test_badinputs (Failed)
    487 - footprintmerge_app_test_360Boundary (Failed)
    488 - footprintmerge_app_test_default (Failed)
    577 - isisminer_app_test_pdstableformat (Failed)
    582 - isisminer_app_test_stereopair (Failed)
    583 - isisminer_app_test_stereopair2 (Failed)
    738 - spiceinit_app_test_shapemodel (Failed)
    824 - csspckgen_app_test_default (Failed)
    911 - dawn_module_test_dawn (Failed)
    981 - lro_module_test_lroc (Failed)
    1012 - mdiscal_app_test_warnings (Failed)
    1016 - mdisedrinfo_app_test_kernelchk (Failed)
    1046 - hicalbeta_app_test_default (Failed)
    1047 - hicalbeta_app_test_dnpermicrosecs (Failed)
    1048 - hicalbeta_app_test_dns (Failed)
    1049 - hicalproc_app_test_default (Failed)
    1050 - hicalproc_app_test_destripe (Failed)
    1051 - hicalproc_app_test_furrows (Failed)
    1113 - osirisrex_module_test_mapcam (Failed)
    1487 - DefaultCube.FunctionalTestNoprojExpand (Failed)
    1888 - HicalTest.Default (Failed)
    1889 - HicalTest.Dns (Failed)
    1890 - HicalTest.DnsPerMicrosecond (Failed)

acpaquette commented 2 days ago

@AustinSanders I have updates to test data for the failing ISIS tests

github-actions[bot] commented 2 days ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5573".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette commented 2 days ago

@AustinSanders All the tests failing that are not currently failing on dev should be data area changes. Once this gets approved and merged I can get those tests updated

github-actions[bot] commented 1 day ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5573".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.