DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
200 stars 168 forks source link

Noproj STILL doesn't clean up all files! #5577

Closed kledmundson closed 1 month ago

kledmundson commented 3 months ago

ISIS version(s) affected: dev

Description

In testing the noproj app for upcoming modifications, Sarah Sutton (@artmathgirl) discovered that there was still a persistent temporary match file (extension lbl; e.g. matchXXXX.lbl) remaining after running noproj. This results from not closing the match cube after returning from the call to cam2cam (and sadly, I didn't catch it) e.g. ...

Code snippet from noproj.cpp (~line 375)... // And run cam2cam to apply the transformation QVector args = {"to=" + ui.GetCubeName("TO"), "INTERP=" + ui.GetString("INTERP")}; UserInterface cam2camUI(FileName("$ISISROOT/bin/xml/cam2cam.xml").expanded(), args); Cube matchCube; matchCube.open(matchCubeFile.expanded(), "rw"); cam2cam(icube, &matchCube, cam2camUI); matchCube.close(); THE MISSING LINE

How to reproduce

Possible Solution

Close the matchCube.

Additional context

Related issue...

https://github.com/DOI-USGS/ISIS3/issues/4813