DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
197 stars 166 forks source link

Bug fix in noproj to remove persistent temporary lbl file #5578

Closed kledmundson closed 1 month ago

kledmundson commented 1 month ago

In testing the noproj app for upcoming modifications, Sarah Sutton (@artmathgirl) discovered that there was still a persistent temporary match file (extension lbl; e.g. matchXXXX.lbl) remaining after running noproj. This results from not closing the match cube after returning from the call to cam2cam (and sadly, I didn't catch it) e.g. ...

Code snippet from noproj.cpp (~line 375)... // And run cam2cam to apply the transformation QVector args = {"to=" + ui.GetCubeName("TO"), "INTERP=" + ui.GetString("INTERP")}; UserInterface cam2camUI(FileName("$ISISROOT/bin/xml/cam2cam.xml").expanded(), args); Cube matchCube; matchCube.open(matchCubeFile.expanded(), "rw"); cam2cam(icube, &matchCube, cam2camUI); matchCube.close(); THE MISSING LINE

Description

Added the line to close the matchCube in noproj.cpp.

Related Issue

https://github.com/DOI-USGS/ISIS3/issues/5577 https://github.com/DOI-USGS/ISIS3/issues/4813

How Has This Been Validated?

noproj tests were rerun, all pass on Mac except for DefaultCube.FunctionalTestNoprojFromUser.

Note that this test seems to be failing in the current ISIS dev but was passing after the last two noproj PRs.

There are very subtle differences in hist->Average() hist->Sum()

Having some trouble explaining that, but sure that this isn't a result of this bug fix.

Types of changes

Checklist:

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

github-actions[bot] commented 1 month ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5578".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.