Isisminer has been refactored to be callable and Makefile tests converted to gtest format

kledmundson commented 1 month ago

Description

The isisminer app has been refactored to be callable and Makefile tests converted to gtest format. There were 23 Makefile tests. Some of these were broken up into multiple tests, resulting in 32 gtests. Also added the method compareCsvLineCustomDelimiter to TestUtilities.cpp to allow for a custom delimiter when comparing lines. This was required for one of the gtests.

How Has This Been Validated?

ctest suite results...

ctest -R Isisminer --output-on-failure Test project /Users/kledmundson/ISISDev/isisminer/June042024/ISIS3/build Start 1951: Isisminer.IsisminerTestAssetSideBar 1/32 Test #1951: Isisminer.IsisminerTestAssetSideBar ................................................. Passed 0.91 sec Start 1952: Isisminer.IsisminerTestCalculator 2/32 Test #1952: Isisminer.IsisminerTestCalculator ................................................... Passed 0.78 sec Start 1953: Isisminer.IsisminerTestCnetReader 3/32 Test #1953: Isisminer.IsisminerTestCnetReader ................................................... Passed 0.88 sec Start 1954: Isisminer.IsisminerTestCsvReader 4/32 Test #1954: Isisminer.IsisminerTestCsvReader .................................................... Passed 0.78 sec Start 1955: Isisminer.IsisminerTestCsvWriter 5/32 Test #1955: Isisminer.IsisminerTestCsvWriter .................................................... Passed 0.80 sec Start 1956: Isisminer.IsisminerTestDatabaseReader 6/32 Test #1956: Isisminer.IsisminerTestDatabaseReader ............................................... Passed 0.81 sec Start 1957: Isisminer.IsisminerTestFilter 7/32 Test #1957: Isisminer.IsisminerTestFilter ....................................................... Passed 0.84 sec Start 1958: Isisminer.IsisminerTestGisIntersect 8/32 Test #1958: Isisminer.IsisminerTestGisIntersect ................................................. Passed 1.33 sec Start 1959: Isisminer.IsisminerTestGisOverlap 9/32 Test #1959: Isisminer.IsisminerTestGisOverlap ................................................... Passed 1.50 sec Start 1960: Isisminer.IsisminerTestGisUnion 10/32 Test #1960: Isisminer.IsisminerTestGisUnion ..................................................... Passed 0.89 sec Start 1961: Isisminer.IsisminerTestIsNumeric 11/32 Test #1961: Isisminer.IsisminerTestIsNumeric .................................................... Passed 0.80 sec Start 1962: Isisminer.IsisminerTestLimit 12/32 Test #1962: Isisminer.IsisminerTestLimit ........................................................ Passed 0.80 sec Start 1963: Isisminer.IsisminerTestNumericalSort 13/32 Test #1963: Isisminer.IsisminerTestNumericalSort ................................................ Passed 0.81 sec Start 1964: Isisminer.IsisminerTestNumericalSortError 14/32 Test #1964: Isisminer.IsisminerTestNumericalSortError ........................................... Passed 0.79 sec Start 1965: Isisminer.IsisminerTestPdsTableCreator 15/32 Test #1965: Isisminer.IsisminerTestPdsTableCreator .............................................. Passed 0.84 sec Start 1966: Isisminer.IsisminerTestPdsTableFormat 16/32 Test #1966: Isisminer.IsisminerTestPdsTableFormat ............................................... Passed 0.85 sec Start 1967: Isisminer.IsisminerTestPdsTableReader 17/32 Test #1967: Isisminer.IsisminerTestPdsTableReader ............................................... Passed 0.97 sec Start 1968: Isisminer.IsisminerTestPvlReader 18/32 Test #1968: Isisminer.IsisminerTestPvlReader .................................................... Passed 0.82 sec Start 1969: Isisminer.IsisminerTestSidebar 19/32 Test #1969: Isisminer.IsisminerTestSidebar ...................................................... Passed 0.81 sec Start 1970: Isisminer.IsisminerTestSidebarException 20/32 Test #1970: Isisminer.IsisminerTestSidebarException ............................................. Passed 0.79 sec Start 1971: Isisminer.IsisminerTestSidebarDebug 21/32 Test #1971: Isisminer.IsisminerTestSidebarDebug ................................................. Passed 0.77 sec Start 1972: Isisminer.IsisminerTestStereoPair 22/32 Test #1972: Isisminer.IsisminerTestStereoPair ................................................... Passed 8.69 sec Start 1973: Isisminer.IsisminerTestStereoPair2 23/32 Test #1973: Isisminer.IsisminerTestStereoPair2 .................................................. Passed 9.60 sec Start 1974: Isisminer.IsisminerTestStrategyFactoryNoIsisMinerObject 24/32 Test #1974: Isisminer.IsisminerTestStrategyFactoryNoIsisMinerObject ............................. Passed 0.78 sec Start 1975: Isisminer.IsisminerTestStrategyFactoryUnknownStrategy 25/32 Test #1975: Isisminer.IsisminerTestStrategyFactoryUnknownStrategy ............................... Passed 0.78 sec Start 1976: IsisminerMainProgram.IsisminerTestMainProgramGlobals 26/32 Test #1976: IsisminerMainProgram.IsisminerTestMainProgramGlobals ................................ Passed 0.78 sec Start 1977: IsisminerMainProgram.IsisminerTestMainProgramNoParameters 27/32 Test #1977: IsisminerMainProgram.IsisminerTestMainProgramNoParameters ........................... Passed 0.78 sec Start 1978: IsisminerMainProgram.IsisminerTestMainProgramParametersIllformed 28/32 Test #1978: IsisminerMainProgram.IsisminerTestMainProgramParametersIllformed .................... Passed 0.79 sec Start 1979: IsisminerResourceManager.FunctionalTestIsisminerResourceManager 29/32 Test #1979: IsisminerResourceManager.FunctionalTestIsisminerResourceManager ..................... Passed 0.82 sec Start 1980: IsisminerResourceManager.FunctionalTestIsisminerResourceManagerDebug 30/32 Test #1980: IsisminerResourceManager.FunctionalTestIsisminerResourceManagerDebug ................ Passed 0.81 sec Start 1981: IsisminerResourceManager.FunctionalTestIsisminerResourceManagerIllFormedException 31/32 Test #1981: IsisminerResourceManager.FunctionalTestIsisminerResourceManagerIllFormedException ... Passed 0.80 sec Start 1982: IsisminerResourceManager.FunctionalTestIsisminerResourceManagerNoAssetException 32/32 Test #1982: IsisminerResourceManager.FunctionalTestIsisminerResourceManagerNoAssetException ..... Passed 0.78 sec

100% tests passed, 0 tests failed out of 32

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation change (update to the documentation; no code change)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

[X] I have read and agree to abide by the Code of Conduct
[X] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] I have added myself to the .zenodo.json document.
[X] I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

[X] I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions[bot] commented 1 month ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5579".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions[bot] commented 1 month ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5579".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs commented 4 weeks ago

PR has merge conflicts.

github-actions[bot] commented 4 weeks ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5579".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette commented 2 weeks ago

@kledmundson Conflicts need to be updated here as well

github-actions[bot] commented 2 weeks ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5579".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

DOI-USGS / ISIS3