Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed.

kledmundson commented 1 month ago

Description

The noseam application has been refactored to be callable. The existing Makefile test has been converted to a gtest utilizing the ThreeImageNetwork test fixture. Additional tests have been added. The Makefile test has been removed.

How Has This Been Validated?

ctest suite results...

ctest -R Noseam --output-on-failure Test project /Users/kledmundson/ISISDev/noseam/Jul182024/ISIS3/build Start 1255: ThreeImageNetwork.FunctionalTestNoseamDefault 1/5 Test #1255: ThreeImageNetwork.FunctionalTestNoseamDefault ................ Passed 5.65 sec Start 1256: ThreeImageNetwork.FunctionalTestNoseamEvenBoxFilterSamples 2/5 Test #1256: ThreeImageNetwork.FunctionalTestNoseamEvenBoxFilterSamples ... Passed 2.82 sec Start 1257: ThreeImageNetwork.FunctionalTestNoseamEvenBoxFilterLines 3/5 Test #1257: ThreeImageNetwork.FunctionalTestNoseamEvenBoxFilterLines ..... Passed 2.85 sec Start 1258: ThreeImageNetwork.FunctionalTestNoseamNoBoxFilterSamples 4/5 Test #1258: ThreeImageNetwork.FunctionalTestNoseamNoBoxFilterSamples ..... Passed 1.65 sec Start 1259: ThreeImageNetwork.FunctionalTestNoseamNoBoxFilterLines 5/5 Test #1259: ThreeImageNetwork.FunctionalTestNoseamNoBoxFilterLines ....... Passed 1.66 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) = 14.83 sec

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation change (update to the documentation; no code change)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

[X] I have read and agree to abide by the Code of Conduct
[X] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[ ] I have added myself to the .zenodo.json document.
[X] I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

[X] I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions[bot] commented 1 month ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5600".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs commented 4 weeks ago

Two test failures for this PR: 1255 - ThreeImageNetwork.FunctionalTestNoseamDefault (Failed) 1256 - ThreeImageNetwork.FunctionalTestNoseamEvenBoxFilterSamples (Failed)

github-actions[bot] commented 3 weeks ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5600".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette commented 2 weeks ago

@kledmundson Change log needs to be updated here as well

amystamile-usgs commented 2 weeks ago

👍 Looks good to me. Just needs merge conflicts fixed before approving.

github-actions[bot] commented 2 weeks ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5600".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette commented 2 weeks ago

@kledmundson Looks like one last merge conflict needs to be resolved here

github-actions[bot] commented 2 weeks ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5600".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

DOI-USGS / ISIS3