Bug fixed in isisminer to properly handle self-intersecting polygon geometries.

Description

The isisminer application detects bad polygons, reports them, and terminates instead of attempting to repair them. Often (though not always), self-intersecting polygons can be repaired by creating a buffer of size 0 around the polygon.

Here, the Strategy and GisGeometry classes have been updated to better manage geometries. The buffer(0) method was added to GisGeometry to repair self-intersecting polygons. The RepairInvalidGeometry and InvalidGeometryAction keywords have been added to the Strategy class providing improved user control over invalid geometries.

The RepairInvalidGeometry keyword defaults to true so that invalid geometries will be repaired. Options for the InvalidGeometryAction keyword are continue, disable or error. For InvalidGeometryAction = continue, the state of the invalid geometry is retained in the Resource (some GIS operations still function) and it is not disabled and no error occurs - the issue is ignored. If InvalidGeometryAction = disable, then the geometry is retained in the Resource but the status is set to "discard". It can be re-enabled by using the ResourceManager strategy. If InvalidGeometryAction = error, then an error is thrown and isisminer terminates. The default value is disable.

Related Issue

https://github.com/DOI-USGS/ISIS3/issues/5612 ## How Has This Been Validated?

The GisGeometry unit test has been modified to test the validity and repair of a self-intersecting polygon. The Strategy unit test has been updated to test the behavior of the two new keywords RepairInvalidGeometry and InvalidGeometryAction.

GisGeometry unit test result

ctest -R GisGeometry --output-on-failure Start 108: isis_unit_test_GisGeometry 1/1 Test #108: isis_unit_test_GisGeometry ....... Passed 2.01 sec

Strategy unit test result

ctest -R isis_unit_test_Strategy --output-on-failure Start 299: isis_unit_test_Strategy 1/1 Test #299: isis_unit_test_Strategy .......... Passed 0.56 sec

Additionally, all isisminer app tests continue to pass.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation change (update to the documentation; no code change)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

[X] I have read and agree to abide by the Code of Conduct
[X] I have read the CONTRIBUTING document.
[X] My change requires a change to the documentation and I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] I have added myself to the .zenodo.json document.
[X] I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

[X] I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

DOI-USGS / ISIS3