DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
200 stars 169 forks source link

Fixes to correct handling of radius in jigsaw gui and bundleout.txt for a rectangular (XYZ) bundle adjustment. #5643

Closed kledmundson closed 3 weeks ago

kledmundson commented 1 month ago

Description

In the jigsaw gui, if the CONTROL_POINT_COORDINATE_TYPE_BUNDLE under "Control Point Parameters" is RECTANGULAR, then the RADIUS checkbox under "Solve Options" should be excluded. Also, with error propagation turned on in a rectangular (XYZ) solution, uncertainty statistics for Point Z coordinates are not reported in the "POINTS UNCERTAINTY SUMMARY" section. Instead, the RMS, MIN, and MAX of RADIUS coordinates is reported as "N/A."

Fixes are as follows...

1) The RADIUS checkbox in the jigsaw GUI is now excluded when a RECTANGULAR solution is selected.

2) For rectangular solutions, in the bundleout.txt file...

3) Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section.

4) Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution.

Related Issue

https://github.com/DOI-USGS/ISIS3/issues/5642

How Has This Been Validated?

All jigsaw and bundle related tests continue to pass (except by the way for the ApolloNetwork.FunctionalTestJigsawSaveApplyValues test, which is also failing in dev on OSX). As above, the FunctionalTestJigsawBundleXYZ ctest was modified to verify that RADIUS is N/A in a RECTANGULAR solution.

Also, reconfirmed output RMS, MIN, MAX of adjusted point coordinates in both Latitudinal and Rectangular solutions by comparing with the points.csv file.

Types of changes

Checklist:

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

github-actions[bot] commented 1 month ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5643".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.