adminstrative code review

[AustinSanders]

An administrative code review must be concluded as part of this repository's release process. Per DOI policy, the administrative review should determine that the repository is free of:

• Personally identifiable information (PII)
• Absolute file system paths
• Internal server host names or IP Addresses
• Username/Passwords

This issue and subsequent discussion will serve as an archive of the review conducted on 9/13/2023.

[AustinSanders]

Internal host names / ip addresses ✅

grep -rE "\b((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(\.|$)){4}\b" . (standard grep for ip addresses) yields no results. grep -rE "://" and grep -rlni "host" " . results in several matches, none of which contain any hostnames.

Personally Identifiable Information (PII) ✅

grep -rE "\b((\+|\b)[1l][\-\. ])?\(?\b[\dOlZSB]{3,5}([\-\. ]|\) ?)[\dOlZSB]{3}[\-\. ][\dOlZSB]{4}\b" . (grep for phone numbers) yields no results

grep -rE "\b\d{1,8}\b[\s\S]{10,100}?\b(AK|AL|AR|AZ|CA|CO|CT|DC|DE|FL|GA|HI|IA|ID|IL|IN|KS|KY|LA|MA|MD|ME|MI|MN|MO|MS|MT|NC|ND|NE|NH|NJ|NM|NV|NY|OH|OK|OR|PA|RI|SC|SD|TN|TX|UT|VA|VT|WA|WI|WV|WY)\b\s\d{5}\b" . (grep for US addresses) yields no results

`grep -rE '^[A-Za-z0-9+._-]+@([a-zA-Z0-9-]+.)+[a-zA-Z]{2,6}$' . (grep for email addresses) yields no results

grep -rE "\b(birth|birthdate|birthday|dob|born)\W+(?:\w+\W+){0,5}?(?<REDACT>(\d{4}|\d{1,2})[\/\-]\d{1,2}[\/\-](\d{4}|\d{1,2}))\b" . (grep for birth date) yields no results

Usernames / passwords ✅

grep -rE "(user|username)" . (search for username) yields multiple results that were manually checked to ensure that no usernames were included

grep -rE "(password|passwd|pwd|pswd|pswrd)" . yields no results

Absolute file system paths ✅

grep -rE "^(\/[^\/]+){3,}$" . results in multiple absolute file system paths that reveal the location of kernels. While these kernels are publicly available, it is unclear whether the inclusion of the path within USGS file system is necessary. It is worth noting that all absolute file paths are contained within a single file -- isisKernelList.txt

Appears that this has been remediated, and now passes absolute file system path check

[Kelvinrr]

Thanks Austin for the review.

@chkim-usgs Seems like all we need is to remove isisKernelList.txt

Keep in mind it's not enough to just remove it from the repo, we need to scrub it from the history. In the past I've used https://rtyley.github.io/bfg-repo-cleaner/ but https://git-scm.com/docs/git-filter-branch is also an option

[chkim-usgs]

Appropriate changes were made to main to remove isisKernelList.txt from the repo and history.