search

DOI-USGS / ale

Abstraction Layer for Ephemerides (ALE)
Other
13 stars 33 forks source link

Domain Review #441

Closed jessemapel closed 2 years ago

jessemapel commented 2 years ago

This issue is for the Domain Review step of the USGS release process. More information can be found on the USGS Software Management Website.

jessemapel commented 2 years ago

@thareUSGS Please respond in a comment on here with the results of the review.

thareUSGS commented 2 years ago

A domain review has been conducted on this software the week of 03/25/22.

ALE is a library to support metadata (SPICE or spacecraft pointing) for individual images in support of camera models as used by usgscsm library. The use of ALE and usgscsm library has been tested, using knoten (currently internal to USGS), against the camera models under the well-establish ISIS photogrammetry suite. A table of comparisons between ALE/usgscsm's output and ISIS's output can be found at the USGS Gitlab knoten site and the Jupyter notebooks used to generate those results.

Beyond the well documented code, ALE consists of a suite for regression testing and example Jupyter notebooks to show how it is used. I will submit a pull request to update minor spelling issues (mostly in the code comments).

Based on the results of the comparison, this software passes domain review.

thareUSGS commented 2 years ago

pull request from branch is now available for review: https://github.com/USGS-Astrogeology/ale/pull/445

jessemapel commented 2 years ago

@thareUSGS Thank you very much!