search

DOI-USGS / ale

Abstraction Layer for Ephemerides (ALE)
Other
13 stars 33 forks source link

Allow ALE NaifSpice Mixins to Access SpiceQL service #523

Closed acpaquette closed 3 weeks ago

acpaquette commented 1 year ago

This update enables the default NaifSpice mixin to access the SpiceQL service, with an example driver updated to test (MroCtxIsisLabelNaifSpiceDriver and MroCtxPds3LabelNaifSpiceDriver).

Both work as expected and can be tested with: MroCtxIsisLabelNaifSpiceDriver("/Path/to/my/isis/cube.cub", props={"web": True}) or MroCtxPds3LabelNaifSpiceDriver("/Path/to/my/pds3/label.[lbl|img], props={"web": True})

Keep in mind that so far, this process is much slower over the net and we are still working to improve the speed of the SpiceQL service.

acpaquette commented 1 year ago

@jlaura This has not been fully tested yet as much of the mocking that happens in the test was not addressed. Basically anything that was mocking a spice call needs to now mock the spiceql_call function. Something that will be addressed in a future sprint where I will go in and basically fix every current NaifSpice driver/tests.

acpaquette commented 1 year ago

Also regarding testing the spice sources. I think it's going to be a trust issue, mainly when web is enabled. Pretty much every drivers load test will test passing in kernels manually, and the metakernel discovery function is also tested.

I am not sure if ALE has a responsibility to test if the server returns are accurate. I think we testing the spiceql_call function is necessary but outside of that it's spiceql's problem

Kelvinrr commented 3 weeks ago

Closing in favor of https://github.com/DOI-USGS/ale/pull/621