codecov-commenter
commented
1 year ago Codecov Report
Merging #551 (5f71e13) into main (5965330) will decrease coverage by
0.03%. The diff coverage is0.00%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
- Coverage 16.91% 16.89% -0.03%
==========================================
Files 54 54
Lines 5865 5872 +7
==========================================
Hits 992 992
- Misses 4873 4880 +7 | Files Changed | Coverage Δ | |
|---|---|---|
| ale/util.py | 0.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Users were dealing with weird interactions between ALE and ISIS w.r.t. ISIS preference files. If users had old preference files there paths would expand as such:
$lro/path/to/lro/kernel$ISIS3DATA/lro/path/to/lro/kernel$ISISDATA/lro/path/to/lro/kernelThen stop there since we only expected paths to contain one ISIS preference defined variable and one os.environ variable. This prevents ALE from being able to get spice data for anything since the paths didn't fully unwrap.
This PR changes the expandvar function to expand all IsisPreference variables and env variables. If we cannot expand a variable the function now errors out.