DOI-USGS / ale

Abstraction Layer for Ephemerides (ALE)
Other
13 stars 33 forks source link

Replace affine6p transformation with numpy solution #579

Closed chkim-usgs closed 1 year ago

chkim-usgs commented 1 year ago

Addresses https://github.com/DOI-USGS/ale/issues/573

The numpy solution is from https://stackoverflow.com/a/20555267.

Both the numpy solution and affine6p solution uses the least squares method (repo link for affine6p here).

This file affine_differences.txt shows the pytest difference output between the affine6p and numpy transformation estimations, respectively. The numpy output is fairly accurate to around the 10th decimal in comparison to the existing affine6p output in the test_naif_keywords() test.

Updated the test_lo_drivers.py to assert the TRANSX, TRANSY, ITRANSS, and ITRANSL values are almost equal to the affine6p output.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

codecov-commenter commented 1 year ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.24%. Comparing base (b9a28e6) to head (df000a4). Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
ale/drivers/lo_drivers.py 0.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #579 +/- ## ========================================== - Coverage 16.25% 16.24% -0.01% ========================================== Files 56 56 Lines 6116 6119 +3 ========================================== Hits 994 994 - Misses 5122 5125 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.