DOI-USGS / ale

Abstraction Layer for Ephemerides (ALE)
Other
13 stars 33 forks source link

Msl Landed Fix #590

Closed acpaquette closed 8 months ago

acpaquette commented 10 months ago

Updated what the "landed" props argument does for MSL. To get accurate sky projections in ISIS we just need to invert the focal length and set the spacecraft (rover) position to the center of the target body.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

codecov-commenter commented 10 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.71%. Comparing base (775ff21) to head (975d2db). Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
ale/drivers/msl_drivers.py 0.00% 3 Missing :warning:
ale/base/type_sensor.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #590 +/- ## ========================================== - Coverage 15.82% 15.71% -0.11% ========================================== Files 56 57 +1 Lines 6283 6326 +43 ========================================== Hits 994 994 - Misses 5289 5332 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.