Enable haybusa2 ONC IsisLabelNaifSpice driver

DOI-USGS / ale

Abstraction Layer for Ephemerides (ALE)

Other

13 stars 33 forks source link

Enable haybusa2 ONC IsisLabelNaifSpice driver #596

Closed acpaquette closed 8 months ago

acpaquette commented 8 months ago

Enables the hayabusa2 ONC ISISLabelNaifSpice driver for use in ISIS to get spice data. See the attached image for verification of ephemeris data:

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

[X] I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Kelvinrr commented 8 months ago

Was the driver okay to begin with?

also needs a changelog entry

acpaquette commented 8 months ago

@Kelvinrr The ephemeris data that the driver produces is very close to ISIS as is. The driver was likely disabled to prevent people from making ISDs as the USGSCSM model has not been compared to the ISIS model and is likely incorrect.

codecov-commenter commented 8 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.14%. Comparing base (6618a19) to head (91d7c83). Report is 18 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #596 +/- ## ========================================== - Coverage 15.47% 15.14% -0.34% ========================================== Files 57 58 +1 Lines 6423 6563 +140 ========================================== Hits 994 994 - Misses 5429 5569 +140 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.