New features should include all of the following work:
[x] Create the function/code
[x] Create tests in tests/testthat folder
[x] Create help file using roxygen2 above code.
[x] Create working examples in help file (via roxygen2)
[x] Add to appropriate vignette (or create new one)
[x] Add example README
[x] Check that devtools::check() produces no errors, warnings, or notes
[x] Check that covr::package_coverage() has not significantly decreased
Feel free to create independent issues for each of these subtasks.
This task should not be considered completed until all of the above boxes are checked, or a reasonable argument is made for ignoring a section (ie...not appropriate for top-level README overview).
It would be helpful to pass the reachcode and measure through into the response from findNLDI.
As in: https://labs.waterdata.usgs.gov/api/nldi/linked-data/nwissite/USGS-06287800/navigation/UT/ref_gage?f=json&distance=10
This needs to be changed here. https://github.com/USGS-R/dataRetrieval/blob/629d82953fa385a5511a4baf4d7057e6e732952e/R/findNLDI.R#L20
I'll submit a PR for this shortly.
New features should include all of the following work:
devtools::check()produces no errors, warnings, or notescovr::package_coverage()has not significantly decreasedFeel free to create independent issues for each of these subtasks. This task should not be considered completed until all of the above boxes are checked, or a reasonable argument is made for ignoring a section (ie...not appropriate for top-level README overview).