This PR modifies the findNLDI function to handle two changes in the NLDI response.
The first was raised in #623 and relates to requests that return no data. The behavior now is a more clear warning message that no data was found rather then the crypitc jsonlite/sf error message.
The second was a change in the NLDI that defaulted to HTML landing pages (raised in internetofwater/nldi-services#315). The behavior now is that a JSON object is explicitly requested in the URLs constructed in findNLDI (opposed to relying on a default).
All tests pass locally as well. Please let me know if anything else needs changing!
ldecicco-USGS
commented
2 years ago
Hi @ldecicco-USGS,
This PR modifies the
findNLDIfunction to handle two changes in the NLDI response.The first was raised in #623 and relates to requests that return no data. The behavior now is a more clear warning message that no data was found rather then the crypitc
jsonlite/sferror message.The second was a change in the NLDI that defaulted to HTML landing pages (raised in internetofwater/nldi-services#315). The behavior now is that a JSON object is explicitly requested in the URLs constructed in
findNLDI(opposed to relying on a default).All tests pass locally as well. Please let me know if anything else needs changing!
Mike