search

DOI-USGS / dataRetrieval

This R package is designed to obtain USGS or EPA water quality sample data, streamflow data, and metadata directly from web services.
https://doi-usgs.github.io/dataRetrieval/
Other
260 stars 84 forks source link

New notes #628

Closed ldecicco-USGS closed 2 years ago

ldecicco-USGS commented 2 years ago

Need to get rid of:

* checking R code for possible problems ... NOTE
Found if() conditions comparing class() to string:
File 'dataRetrieval/R/importNGWMN_wml2.R': if (class(input) == "character" && file.exists(input)) ...
File 'dataRetrieval/R/importNGWMN_wml2.R': if (class(input) == "raw") ...
File 'dataRetrieval/R/importWaterML1.r': if (class(obs_url) == "character" && file.exists(obs_url)) ...
File 'dataRetrieval/R/importWaterML1.r': if (class(obs_url) == "raw") ...
File 'dataRetrieval/R/readWQPdots.R': if (class(values["zip"]) == "logical") ...
Use inherits() (or maybe is()) instead.