search

DOI-USGS / dataRetrieval

This R package is designed to obtain USGS or EPA water quality sample data, streamflow data, and metadata directly from web services.
https://doi-usgs.github.io/dataRetrieval/
Other
256 stars 85 forks source link

Fixes to issue #610. #632

Closed alkrall closed 1 year ago

alkrall commented 1 year ago

Fixes to issue #610

ldecicco-USGS commented 1 year ago

When you click "Install" from the Build tab, you should be updating the .Rd files. If not, in that same Build tab, click More -> Configure Build Tools -> then click the checkbox for "Generate documentation with Roxygen".

Once that's done, you should see a few .Rd files that need to be committed and then Pushed up to this PR. The R Check that is giving some Warnings are saying the help files need some information on this new argument "convertType". I see you updated the Roxygen code above the functions themselves, but we need that Roxygen code to actually update the .Rd files in the man folder.

alkrall commented 1 year ago

Hi Laura, Let me know if I addressed these correctly.

Aliesha L. Krall Physical Scientist U.S. Geological Survey Upper Midwest Water Science Center 2280 Woodale Drive Mounds View, MN 55112 office: 763-783-3135 https://www.usgs.gov/staff-profiles/aliesha-l-diekoff

From: Laura DeCicco @.> Sent: Monday, August 22, 2022 1:12 PM To: USGS-R/dataRetrieval @.> Cc: Krall, Aliesha L @.>; Author @.> Subject: [EXTERNAL] Re: [USGS-R/dataRetrieval] Fixes to issue #610. (PR #632)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

When you click "Install" from the Build tab, you should be updating the .Rd files. If not, in that same Build tab, click More -> Configure Build Tools -> then click the checkbox for "Generate documentation with Roxygen".

Once that's done, you should see a few .Rd files that need to be committed and then Pushed up to this PR. The R Check that is giving some Warnings are saying the help files need some information on this new argument "convertType". I see you updated the Roxygen code above the functions themselves, but we need that Roxygen code to actually update the .Rd files in the man folder.

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSGS-R%2FdataRetrieval%2Fpull%2F632%23issuecomment-1222740490&data=05%7C01%7Cakrall%40usgs.gov%7C6a30ed8cd7fe42c1e37008da8469e02b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637967887511462403%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rdZAy7q5LGzhXFPjCaFN3wWOzGPrg31H%2Bf4gj67UcgU%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWZUANDTM2TN5TAMAJOGDJTV2O7IVANCNFSM56W3J6CQ&data=05%7C01%7Cakrall%40usgs.gov%7C6a30ed8cd7fe42c1e37008da8469e02b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637967887511462403%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FZQ32%2FqJuyJfjFdLAfdqpOh8qVLznAP4bEf9DBAjIdY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

ldecicco-USGS commented 1 year ago

We're going pull this, and either myself or Aliesha will fix the broken tests.