search

DOI-USGS / dataRetrieval

This R package is designed to obtain USGS or EPA water quality sample data, streamflow data, and metadata directly from web services.
https://doi-usgs.github.io/dataRetrieval/
Other
256 stars 85 forks source link

Fix return structure, bug in url constructor, test, and add warn flag… #645

Closed mikejohnson51 closed 1 year ago

mikejohnson51 commented 1 year ago

All with respect to USGS-R/dataRetrieval #623:

Hi @ldecicco-USGS!

This PR does four things:

  1. Ensures that all returned objects are a list structure (even when a single element exists)
  2. Fixes a bug where a space was added to the URL constructor for distance arguments
  3. Adds a warn flag to get_nldi and findNLDI to optionally suppress warning messages
  4. Updates all tests

All tests pass locally and documentation has been updated!

Let me know if anything else is needed,

Mike