search

DOI-USGS / dataretrieval-python

Python package for retrieving water data from USGS or the multi-agency Water Quality Portal
https://doi-usgs.github.io/dataretrieval-python/
Other
165 stars 41 forks source link

[#157] Example notebook for NLDI data access #158

Closed pkdash closed 4 weeks ago

pkdash commented 2 months ago

@thodson-usgs I am waiting for Jeff to do some final edits to the new notebook for nldi data access. After that I it should be ready for review.

pkdash commented 1 month ago

@thodson-usgs It is now ready for review. Thanks.

ehinman commented 1 month ago

@pkdash I will take a look in the next week. Thanks for contributing!

thodson-usgs commented 4 weeks ago

I would just add that @ehinman makes some good points, but some seem out of scope of the PR and will be for us to follow up later.

I also feel that the nldi module could benefit from more detailed descriptions of what the arguments do/mean. For example, what is stop_comid in get_flowlines(), and what does trim_start() trim?

After reviewing our own swagger doc, I'm also confused. As these functions aren't implemented in the PR, this is a little out of scope and perhaps not something @pkdash can answer.

dblodgett-usgs commented 4 weeks ago

BTW, we are migrating the NLDI to the URL in that link. If the "labs" url is used in this package, can you change "https://labs.waterdata.usgs.gov/api/nldi/" to "https://api.water.usgs.gov/nldi/" throughout?