DOI-USGS / ds-pipelines-targets-3-course

Many-task pipelines using targets
Other
4 stars 6 forks source link

Review of pipelines 3 up to splitter #6

Closed jzwart closed 3 years ago

jzwart commented 3 years ago

I reviewed the course up to the splitters section.

I only had a few comments / suggestions, otherwise everything seemed to work great!

I do wonder if we want to focus on dynamic branching rather than static branching for the entire course, whether or not the static branching works well with the splitters. Although it is nice to show the visual of what is going on with the static branching, I think there are more benefits to the static branching (and I find it a bit easier to read the _targets.R file when using dynamic branching).

I also had a couple suggestions for terminology used - when talking about tasks, I thought it was appropriate to use the term task targets in a couple places (e.g. here) and might help the course user understand that the task is an actual target for the pipeline (rather than vaguely talking about tasks that need to be done).