DOI-USGS / gems-tools-pro

GeMS Tools for ArcGIS Pro
Creative Commons Zero v1.0 Universal
46 stars 15 forks source link

Validate Database does not detect null DescriptionSourceID values in DescriptionOfMapUnits #102

Closed wynaut closed 6 months ago

wynaut commented 6 months ago

The GeMS publication says that the DescriptionSourceID field in the DescriptionOfMapUnits table is non-nullable: image ...but the Validate Database tool doesn't flag null values in this field as errors. I guess this should be considered an enhancement request?

ethoms-usgs commented 6 months ago

The main problem is with rows in the DMU that are for headings. Those don't necessarily need a description source. Right now the tool only checks rows where there is a value in MapUnit but that misses 1) headnotes, which could have text that maybe should have a source, and 2) units that don't have a MapUnit value, like a parent unit that is not mapped as features on the map but that is "further divided into" child units that are.

wynaut commented 6 months ago

Ah, that makes sense. I was thrown off because the other DMU fields in the documentation specify that they're nullable for headings, but this one doesn't. Since the contents of ParagraphStyle can't be standardized + headings can't be consistently identified, I guess there's nothing to be done about it...