DOI-USGS / gems-tools-pro

GeMS Tools for ArcGIS Pro
Creative Commons Zero v1.0 Universal
49 stars 15 forks source link

New Validate tool issue (v2.11.4): Warning about ValueConfidence (IsoValueLines) definition missing from Glossary #73

Closed alwunder closed 1 year ago

alwunder commented 1 year ago

Running the tool on a database that previously passed validation gives the following Warning:

Warnings
    Terms in GeMS-like fields that do not have definitions in the Glossary.
    All fields ending in type, method, or confidence are checked.
    Please define these terms in Glossary, provide a look-up table, or at minimum define in the metadata
    table IsoValueLines, field ValueConfidence, value 2.0
    table IsoValueLines, field ValueConfidence, value 5.0

The suggestion to add a definition to the Glossary for ValueConfidence seems like a good idea to me, so I did just that. Unfortunately, this causes an error and does not remove the Warning:

Level 3 errors
    3.5 Terms in Glossary that are not used in geodatabase
    ValueConfidence
Warnings
    Terms in GeMS-like fields that do not have definitions in the Glossary.
    All fields ending in type, method, or confidence are checked.
    Please define these terms in Glossary, provide a look-up table, or at minimum define in the metadata
    table IsoValueLines, field ValueConfidence, value 2.0
    table IsoValueLines, field ValueConfidence, value 5.0

I understand that if a GeMS-like "type", "method", or "confidence" attribute was used and populated with a text string, that term would need to be defined in the Glossary like other terms. But the ValueConfidence attribute is a special case where the value in the field is not really a definable term, the attribute itself needs explanation as to the purpose of the values contained within it.

Can this be adjusted so if the field ValueConfidence occurs in the database a matching Glossary entry is perceived as valid (and suppress the Warning)? Or should it be ignored by the validation aside from being non-null (e.g., LocationConfidenceMeters)?

ethoms-usgs commented 1 year ago

The problem is that ValueConfidence is a number field (float) and Term is text so values never match. I changed the tool to only check text fields. See v2.12.1

alwunder commented 1 year ago

Excellent. And I will just make sure that ValueConfidence has its meaning explained in the feature class metadata.