Open alwunder opened 11 months ago
Honestly, most of this is intended. I think we only added definitions in GeMS_Definitions for tables and fields that are in the required or as-needed example sections of the GeMS document. Aside from the required SourceID fields, the ones you list are essentially custom fields for which your definition might be a little different from someone else's. And even the SourceID fields, with the addition of the prefixes FossilForms and FossilAge, could have custom definitions. That said, I like your definitions. I doubt few would object if we added them to GeMS_Definitions. I will bring it up.
But with GenericPoints, 'Generic' is meant as a place holder for you to rename with a custom name. It's necessary for the automation of creating database tables but should be changed to describe the first-order 'Type' of the points within.
I am confused about 2. The values in those fields should be documented in the metadata as enumerated domains. It seems to me like the error you are getting is valid and indicating that the values in the fields are not found in the appropriate data dictionary tables; Glossary, DescriptionOfMapUnits, GeoMaterialDict, DataSources. Is that true or is the tool not building the enumerated domain values?
OK, gotcha on the first part, that makes sense and was really no trouble, just wanted to make sure I wasn't missing something.
For 2, I think it's a problem with the tool not building the enumerated domain values, or something along those lines, as you suggested. I thought maybe it was because the gdb was empty that it wasn't working correctly, but I have tested the metadata tool on a bunch of complete, level 3 validated gdbs and the errors persist. When I add the TEST strings back to the definitions, they come through in the output xml file and I get no metadata validation errors from MP.
I can't reproduce those errors. Can you send me an example gdb?
I've been testing the Validate tool and the Build Metadata tool on an empty copy of our complete TNGeMS schema looking for issues. Basically, everything is good. However, I noticed that when running the Build Metadata tool, I am getting a huge number of errors in a couple different categories:
Entity _and_Attribute_Overview
andEntity_and_Attribute_Detail_Citation
for the following entity and attribute items, which should be part of the GeMS definitions:I was able to correct the errors by adding the following lines to
my_definitions.py
myEntityDict
andmyAttribDict
sections:and
Attribute_Domain_Values
. I looked through the metadata tool xml output and found that these errors occur only in fields that are part of theenumeratedValueDomainFieldList
. I was able to correct this by adding the following lines tomy_definitions.py
myUnrepresentableDomainDict
section:It seems there may be an issue in the
# UNREPRESENTABLE DOMAINS
section ofGeMS_FGDCMetadata.py
in theelse:
statement near the end that deals with unrepresentable domains.