DOI-USGS / hurricane-irma

Creative Commons Zero v1.0 Universal
55 stars 20 forks source link

embed ability + social media icons #100

Closed lindsayplatt closed 7 years ago

lindsayplatt commented 7 years ago

The embed figure itself is not correct. embed: true is a vizlab feature, but it's not able to get the correct SVG since we are injecting the svg later on as portrait or landscape. We can choose to 1) move around how we are doing the SVG injection so that the figure-section is where the JS appears, or 2) make a fake section for the embedding that has either landscape or portrait hard-coded.

jordansread commented 7 years ago

My vote is the embed is the desktop version

lindsayplatt commented 7 years ago

I was leaning that way as well

lindsayplatt commented 7 years ago

Embed working -- embed fig not function perfect, but exists. Removed advertisements for embedding (still in viz.yaml and template, just commented out)