search

DOI-USGS / hyRefactor

https://code.usgs.gov/wma/nhgf/reference-fabric/hyrefactor
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Opposed to enforcing raster handling? #20

Closed mikejohnson51 closed 2 years ago

mikejohnson51 commented 3 years ago

Hi @dblodgett-usgs,

Are you opposed to enforcing the transformation and precision setting catchments and raster grids within reconcile_catchment_divides?

Essentially place: 

catchments <-  st_transform(catchments, st_crs(fdr)) 
st_precision(catchments) <- raster::res(fdr)[1]

Within the function?

Mike

dblodgett-usgs commented 3 years ago

No -- sounds fine. -- I wouldn't mind adding this functionality to st_compatiblize over in nhdplusTools too if you want?

mikejohnson51 commented 2 years ago

I believe this is handled in PR #30