This PR moves hyRefactor to terra and away from raster. Along the way general clean up was performed to ensure all tests pass with devtools::test(). While these all pass, the tests run through devtools::check() fail spectacularly.
On my machine this was the case pre-changes, so I am going to submit this. Other (unfortunately
non-exhaustive - bad note taking) things:
This PR moves
hyRefactor
toterra
and away fromraster
. Along the way general clean up was performed to ensure all tests pass withdevtools::test()
. While these all pass, the tests run throughdevtools::check()
fail spectacularly.On my machine this was the case pre-changes, so I am going to submit this. Other (unfortunately non-exhaustive - bad note taking) things:
magrittr
dependency callingdplyr
%>%
insteadtidyr
dependencyrvest::read_html
instead:::
call to nhdplusTools check7z - this should be exported (currently copied here)stringr
dependency with explicitpaste(..., collapse = ",")
methods::is
call, I think we can removemethods::slot
as wellraster
,SpatRast
and paths can be passed directly tofdr
andfac
list.files
. I think all data in inst should be moved to tests to if check is ever going to passrgdal
calls everywhere!