Closed dblodgett-usgs closed 2 years ago
Running this version of the package for region 06a I am getting what I expect now. So that's good.
Merging #50 (e38282e) into main (76bdbb6) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 89.28% 89.30% +0.01%
==========================================
Files 11 11
Lines 1587 1589 +2
==========================================
+ Hits 1417 1419 +2
Misses 170 170
Impacted Files | Coverage Δ | |
---|---|---|
R/aggregate_network.R | 98.20% <100.00%> (ø) |
|
R/catchment_geometry.R | 65.97% <100.00%> (+0.47%) |
:arrow_up: |
R/reconcile.R | 88.70% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This looks correct to me. I think there are some refactoring opportunities (hehe) to separate some concerns in this process but this works!
I found that the core bug was a use of cbind that should have been a left_join. This also introduces some testing and brings back a deprecated function with identical behavior to the old one.
Note that I removed one sf::st_drop_geometry and switched one to an hyRefactor:::drop_geometry.
@mikejohnson51 can you make sure I'm not being dumb here?