DOI-USGS / knoten

Python Geospatial Sensor Exploitation Library
Other
3 stars 21 forks source link

Clean up comparison notebooks and fix vis.py #133

Closed amystamile-usgs closed 3 months ago

amystamile-usgs commented 3 months ago

When cleaning up the comparison notebooks, incorporating the newer ALE implementation essentially standardized the code across all the comparison notebooks. Therefore, I decided it would be more efficient to maintain a single comparison notebook.

closes #108, closes #92, closes #123

I also noticed that vis.py dependencies were not being shipped in the knoten releases (kalasiris and plotly).

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

jlaura commented 3 months ago

Ohh also, kalasiris dependency - can that be optional? Honestly, can all of the vis stuff be optional? For someone not wanting to do a comparison, they are bloat in a CSM library.

amystamile-usgs commented 3 months ago

Ohh also, kalasiris dependency - can that be optional? Honestly, can all of the vis stuff be optional? For someone not wanting to do a comparison, they are bloat in a CSM library.

Maybe not including vis.py dependencies was intentional. I think it would be a good idea not to ship kalasiris with knoten. I can just add instructions to install it in the notebook.

jlaura commented 3 months ago

LGTM!