Open lindsayplatt opened 4 years ago
I think the "donut" bathymetry contour is the reason for this, right?
I haven't confirmed that it is the only reason, but I think it may be part of the reason. Although, the issue with those types of scenarios is that they are not being removed in the final area calc right now BUT that would be happening at all depths. So even though the area calc is wrong, they should still pass this test for monotonicity. So I'm not sure if it is the root cause ...
To elaborate on that so it is more obvious when we return to this after the TOHA push: the st_union
function is removing the internal boundaries before the area calc. This means that lakes with little islands or sand bars (the "donuts" mentioned above) are getting removed. See image below.
The ones listed in "not_working" still have something preventing them from passing monotonicity test. There are 13.
Below is a section of code that I started to test these in
munge_ndgf_bathy
.