DOI-USGS / lake-temperature-model-prep

Pipeline #1
Other
6 stars 13 forks source link

Adding MO US Army Corps of Engineers (USACE) data parser #311

Closed padilla410 closed 2 years ago

padilla410 commented 2 years ago

Overview

This pull request completes the following:

Record Summary

After the initial parsing step, the raw data from MO USACE has 48,186 records. Approximately 55% of these records (26,643) make it into all_coop_dat_linked.feather. There are two main reasons for this:

  1. Not all locations had matches in the spatial look up table. For example the lookup table (Missouri_USACE_samplingLocations.xlsx) has lat/longs for HD2, HD3, HD6, HD11 but not HD10 and HD15.
  2. The point-in-polygon method doesn't always work well for reservoirs. For example, HD2 is in the look up table, but the coordinates are on land (first two images). In other cases, The reservoir is narrow and sinuous and the sampling location (WI9) is near the boundary of the waterbody (Wilson Lake) - this could result in a mismatch between the NHD polygon and the point of interest (third image).

image

image

image

Results from scmake("8_viz")

After completing the above, we pick up 6 more PGDL lakes (compared to https://github.com/USGS-R/lake-temperature-model-prep/pull/288). Snapshot of 8_viz/out/lakes_summary_fig.html:

image

padilla410 commented 2 years ago

@jread-usgs I believe I have addressed all comments, but please take quick peek at the one conversation I have not marked as "resolved". I just want to make sure we have the same understanding on that one.

If you give me a thumbs up, I'll merge this.

jordansread commented 2 years ago

Good to merge @padilla410